rocr: Fix restoring SCHED_MODE in gfx12 trap handler#3255
Open
rocr: Fix restoring SCHED_MODE in gfx12 trap handler#3255
Conversation
The code to restore SCHED_MODE on exit has an issue and incorrectly restores advanced scheduling mode unconditionally. Fix this and restore the expected value. Co-authored-by: Laurent Morichetti <laurent.morichetti@amd.com>
lancesix
requested review from
cfreeamd,
dayatsin-amd and
shwetagkhatri
as code owners
shwetagkhatri
approved these changes
Feb 12, 2026
Contributor
shwetagkhatri
left a comment
shwetagkhatri
left a comment
There was a problem hiding this comment.
Looks correct fix to me. Approved.
lmoriche
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to restore SCHED_MODE on exit has an issue and incorrectly restores advanced scheduling mode unconditionally. Fix this and restore the expected value.