Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new HIP “sanityTests” Catch2 test target intended to exercise basic device-side allocation and host-memory registration paths.
Changes:
- Introduces
SanityTestsCMake target inunit/sanityTestsand adds two new test sources. - Adds stress/sanity coverage for
hipHostRegister/hipHostUnregisterwith multiple sizes and flags. - Adds basic kernels/tests for device-side
new/deleteandmalloc/free, including cross-kernel allocation usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| projects/hip-tests/catch/unit/sanityTests/CMakeLists.txt | Defines new SanityTests executable target with the added sanity test sources. |
| projects/hip-tests/catch/unit/sanityTests/hipHostRegister.cc | Adds host registration/register-unregister stress tests across sizes and flags. |
| projects/hip-tests/catch/unit/sanityTests/deviceSideMalloc.cc | Adds device-side allocation kernels and corresponding Catch2 sanity test cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mangupta
requested changes
Mar 12, 2026
sourabhuday
reviewed
Mar 18, 2026
jungx098
reviewed
Mar 19, 2026
jungx098
requested changes
Mar 19, 2026
jungx098
requested changes
Mar 20, 2026
jungx098
approved these changes
Mar 20, 2026
Contributor
jungx098
left a comment
jungx098
left a comment
There was a problem hiding this comment.
nit: incorrect copyright year in CMakeList.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
shift left : Moved hip sanity tests from ROCmTest to hip catch test
Technical Details
Sanity Tests belongs to Launches kernels that uses device-side malloc/new/free/delete, hipHostRegister APIs.
JIRA ID
https://amd-hub.atlassian.net/browse/AISQA-7710
Test Plan
hip sanity tests:-
Unit_AccessMallocAcrossKernels
Unit_hipHostRegister_RegisterUnregister
Unit_hipHostRegister_Nbuf_MultiFlag_RegisterUnregister
Run command :- ctest -R <test_name>
Test Result
PASSED
Submission Checklist