[WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test#4252
Draft
Copilot wants to merge 2 commits intousers/jaypatel/ROCM-20009from
Draft
[WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test#4252Copilot wants to merge 2 commits intousers/jaypatel/ROCM-20009from
Copilot wants to merge 2 commits intousers/jaypatel/ROCM-20009from
Conversation
1 task
…ual purpose Co-authored-by: jaydeeppatel1111 <106300970+jaydeeppatel1111@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on ROCM-20009 regarding hipStreamCreateWithPriority
[WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After removing time-based assertions in #3950,
validateStreamPrioritiesWithEventsretained event infrastructure that no longer served any purpose—the function only verified kernel output correctness. This PR cleans that up.Motivation
validateStreamPrioritiesWithEventsandUnit_hipStreamCreateWithPriority_ValidateWithEventswere misleadingly named and contained dead code after the timing assertions were dropped. Events were still being created, recorded, and destroyed solely to produce anINFO-level log with no corresponding assertion.Technical Details
hipEventCreate,hipEventRecord(start/end),hipEventElapsedTime,hipEventSynchronize,hipEventDestroyhipEventSynchronize(event_end_##x)withhipStreamSynchronize(stream_##x)for correctnessvalidateStreamPrioritiesWithEvents→verifyStreamPriorityKernelResultsUnit_hipStreamCreateWithPriority_ValidateWithEvents→Unit_hipStreamCreateWithPriority_VerifyKernelResultsprioritiy→priorityin commentJIRA ID
Resolves ROCM-20009
Test Plan
Manual inspection of the updated test logic. Build and run
Unit_hipStreamCreateWithPriority_VerifyKernelResultson a ROCm-enabled device.Test Result
No behavioral change to test logic—only dead event-timing code removed and naming updated to match actual test intent.
Submission Checklist
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.