Skip to content

[WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test#4252

Draft
Copilot wants to merge 2 commits intousers/jaypatel/ROCM-20009from
copilot/sub-pr-3950
Draft

[WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test#4252
Copilot wants to merge 2 commits intousers/jaypatel/ROCM-20009from
copilot/sub-pr-3950

Conversation

Copy link
Contributor

Copilot AI commented Mar 20, 2026

After removing time-based assertions in #3950, validateStreamPrioritiesWithEvents retained event infrastructure that no longer served any purpose—the function only verified kernel output correctness. This PR cleans that up.

Motivation

validateStreamPrioritiesWithEvents and Unit_hipStreamCreateWithPriority_ValidateWithEvents were misleadingly named and contained dead code after the timing assertions were dropped. Events were still being created, recorded, and destroyed solely to produce an INFO-level log with no corresponding assertion.

Technical Details

  • Removed all HIP event machinery: hipEventCreate, hipEventRecord (start/end), hipEventElapsedTime, hipEventSynchronize, hipEventDestroy
  • Replaced hipEventSynchronize(event_end_##x) with hipStreamSynchronize(stream_##x) for correctness
  • Renamed validateStreamPrioritiesWithEventsverifyStreamPriorityKernelResults
  • Renamed Unit_hipStreamCreateWithPriority_ValidateWithEventsUnit_hipStreamCreateWithPriority_VerifyKernelResults
  • Updated test description comment to reflect actual intent: launch kernels on priority streams, synchronize, verify output correctness
  • Fixed typo: prioritiypriority in comment

JIRA ID

Resolves ROCM-20009

Test Plan

Manual inspection of the updated test logic. Build and run Unit_hipStreamCreateWithPriority_VerifyKernelResults on a ROCm-enabled device.

Test Result

No behavioral change to test logic—only dead event-timing code removed and naming updated to match actual test intent.

Submission Checklist


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…ual purpose

Co-authored-by: jaydeeppatel1111 <106300970+jaydeeppatel1111@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on ROCM-20009 regarding hipStreamCreateWithPriority [WIP] Address feedback on ROCM-20009: remove stale event-timing machinery and rename test Mar 20, 2026
Copilot AI requested a review from jaydeeppatel1111 March 20, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants