NULL check environ before dereference - #469
Closed
systems-assistant[bot] wants to merge 2 commits into
Closed
systems-assistant[bot] wants to merge 2 commits into
systems-assistant[bot] wants to merge 2 commits into
Conversation
On UNIX, `clearenv` sets `environ` to NULL. So, NULL is a valid value for `environ`. Signed-off-by: Dušan Veljko <v-dusan@exostellar.io>
…evelop/dusan-exostellar_clr/environ_null_check
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/clr commit: 71c6535]
SwRaw
pushed a commit
that referenced
this pull request
Aug 19, 2025
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
* CMAKE - Remove example build from src/CMakeLists.txt For some reason it was building examples every time even when not necessary... * CMAKE - Format * Fix drm_example broken PRIu32 * CMAKE - Do NOT create lib64 when building examples * CMAKE - Examples should only install C and CMake files --------- Change-Id: I6274b72a085a41b5bd5ae698af798f60a8a092a0 Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
* CMAKE - Remove example build from src/CMakeLists.txt For some reason it was building examples every time even when not necessary... * CMAKE - Format * Fix drm_example broken PRIu32 * CMAKE - Do NOT create lib64 when building examples * CMAKE - Examples should only install C and CMake files --------- Change-Id: I6274b72a085a41b5bd5ae698af798f60a8a092a0 Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com> [ROCm/amdsmi commit: f9b8066]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
* CMAKE - Remove example build from src/CMakeLists.txt For some reason it was building examples every time even when not necessary... * CMAKE - Format * Fix drm_example broken PRIu32 * CMAKE - Do NOT create lib64 when building examples * CMAKE - Examples should only install C and CMake files --------- Change-Id: I6274b72a085a41b5bd5ae698af798f60a8a092a0 Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com> [ROCm/amdsmi commit: f9b8066]
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
[ROCm/rocdecode commit: c02fbcf]
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
Closes ROCm/clr#164
What type of PR is this? (check all applicable)
What were the changes?
NULL check before dereference.
Why are these changes needed?
To prevent dereferencing NULL pointer.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks
🔁 Imported from ROCm/clr#168
🧑💻 Originally authored by @dusan-exostellar