Disable skynny gemms by default #568
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream merge 25 01 27
* updating code blocks * typo * updated manifest * Including feedback * whitespace * Deepseek instructions * hyperlink fix * hyperlink fix * updating what is new * cpx update * typo * whitespace * whitespace
* integrate new cpa kernel, update tests and benchmark * added comments to mfma4 kernel * further comments for mfma16 kernel * clang-format * Lint * add flag for logits rtz conversion and disable by default * lint * [Bugfix]: Fix paged attention unit tests of #372 (#389) * [Bugfix]: fix paged attention tests based on the updated kernels in `csrc/attention/paged_attention_v1.cu`,`csrc/attention/paged_attention_v2.cu` and `csrc/rocm/attention.cu`. * improve code documentation. * lint --------- Co-authored-by: vllmellm <[email protected]> --------- Co-authored-by: Gregory Shtrasberg <[email protected]> Co-authored-by: Gregory Shtrasberg <[email protected]> Co-authored-by: Joe Shajrawi <[email protected]> Co-authored-by: TJian <[email protected]> Co-authored-by: vllmellm <[email protected]>
… quant is not supported Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Hongxia Yang <[email protected]>
* Aiter section * Aiter section in docker * Enablement * Only exposing a single knob * More details on env defaults
…pstream_merge_25_02_03
Correct initial values
Upstream merge 25 02 03
* Enabling P3L.py & P3L_mling.py tests to run with multiple batched queries. This alternation adds minimal measurement noise. The underlining testing material is the same, the resulting measurements are comparable to the old (BS=1) testing runs. Signed-off-by: Alexei V. Ivanov <[email protected]> * Making linters happy. Signed-off-by: Alexei V. Ivanov <[email protected]> * Changed the device specification for the 'forced_sample' tensor. The resulting implementation produces identical measurement, and, actually, became faster (3.21s/it vs 3.42s/it with previous commit). Signed-off-by: Alexei V. Ivanov <[email protected]> * Fixing reporting to reflect processed intervals. Signed-off-by: Alexei V. Ivanov <[email protected]> --------- Signed-off-by: Alexei V. Ivanov <[email protected]>
* fix quark fp8 loading * fix undefined variables --------- Co-authored-by: Bowen Bao <[email protected]>
…n ROCm (#406) Signed-off-by: Gregory Shtrasberg <[email protected]>
* Update README.md 20250205_aiter * whitespace * adding VLLM_USE_AITER=0 advice
* fix rocm get_device name use 'market_name' hard-code names for mi308 & mi300 * use gfx and num_CU for device name * using market_name * rename MI325_OAM to MI325X * rm (duplicate) MI300X_OAM * rename mi308
* Add tuned moe config for qwen1.5_moe_A2.7B * Add more sweep parameters on qwen2_moe * Add tp = 1,2,4,8 after applying PR12838 * Rename config name by deleting "_OAM" --------- Co-authored-by: Gregory Shtrasberg <[email protected]> Co-authored-by: Divakar Verma <[email protected]>
Signed-off-by: charlifu <[email protected]>
Signed-off-by: Gregory Shtrasberg <[email protected]>
* Added benchmark results and commit hash * Added release notes/changelog * Update README.md
Signed-off-by: charlifu <[email protected]>
…tream_merge_2025_05_29
Upstream merge 2025 06 02
Upstream merge 2025 06 03
k-artem
requested review from
charlifu,
mawong-amd,
shajrawi,
gshtras,
maleksan85,
sunway513 and
hongxiayang
as code owners
Enabling of this feature by default in Commit 188b7f9 is broken inference of models via vllm (refs SWDEV-531223), so due to currently support of this feature is limited we propose to disable it by default and enable back when support of Navi will be done.
|
Please note the check at https://github.com/ROCm/vllm/blob/main/vllm/model_executor/layers/utils.py#L75 |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
gshtras
force-pushed
the
main
branch
2 times, most recently
from
1d2c43d to
eb9d4de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling of this feature by default in Commit 188b7f9 is broken inference of models via vllm (refs SWDEV-531223), so due to currently support of this feature is limited we propose to disable it by default and enable back when support of Navi will be done.
Please direct your PRs to the upstream vllm (https://github.com/vllm-project/vllm.git)
Accepting PRs into the ROCm fork (https://github.com/ROCm/vllm) will require a clear previously communicated exception