Update CdactionBridge #4725
Open
Update CdactionBridge #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
last change: Saturday 2025-09-13 13:12:30 |
dvikan
reviewed
Sep 13, 2025
| $newsJson = $html->find('script#__NEXT_DATA__', 0)->innertext; | ||
| if (!$newsJson = json_decode($newsJson)) { | ||
| if ($this->getInput('category') === 'feed') { | ||
| $xml = simplexml_load_file($feedUrl); |
Contributor
There was a problem hiding this comment.
is it possible to drop usage of this function? because it has security implications
Contributor
Author
There was a problem hiding this comment.
Hm, you mean simplexml_load_file? I need to load https://cdaction.pl/feed/ it's XML with all needed data.
I can add some tweaks, like flags LIBXML_NONET | LIBXML_NOERROR | LIBXML_NOWARNING and validate if file is really a xml. Any other suggesions?
Mynacol
requested changes
Oct 29, 2025
Contributor
Mynacol
left a comment
Mynacol
left a comment
There was a problem hiding this comment.
Aside from the Najnowsze (wszystkie) category (which only gets the website-provided feed and uses the already remarked simplexml_load_file function, this bridge throws (at least now) only errors:
Details
Type: ErrorException
Code: 0
Message: Attempt to read property "plaintext" on null
File: bridges/CdactionBridge.php
Line: 53
Trace
#0 index.php(73): RssBridge->main()
#1 lib/RssBridge.php(39): RssBridge->{closure:RssBridge::main():37}()
#2 lib/RssBridge.php(37): BasicAuthMiddleware->__invoke()
#3 middlewares/BasicAuthMiddleware.php(13): RssBridge->{closure:RssBridge::main():37}()
#4 lib/RssBridge.php(37): CacheMiddleware->__invoke()
#5 middlewares/CacheMiddleware.php(44): RssBridge->{closure:RssBridge::main():37}()
#6 lib/RssBridge.php(37): ExceptionMiddleware->__invoke()
#7 middlewares/ExceptionMiddleware.php(17): RssBridge->{closure:RssBridge::main():37}()
#8 lib/RssBridge.php(37): SecurityMiddleware->__invoke()
#9 middlewares/SecurityMiddleware.php(19): RssBridge->{closure:RssBridge::main():37}()
#10 lib/RssBridge.php(37): MaintenanceMiddleware->__invoke()
#11 middlewares/MaintenanceMiddleware.php(10): RssBridge->{closure:RssBridge::main():37}()
#12 lib/RssBridge.php(37): TokenAuthenticationMiddleware->__invoke()
#13 middlewares/TokenAuthenticationMiddleware.php(10): RssBridge->{closure:RssBridge::main():33}()
#14 lib/RssBridge.php(34): DisplayAction->__invoke()
#15 actions/DisplayAction.php(54): DisplayAction->createResponse()
#16 actions/DisplayAction.php(89): CdactionBridge->collectData()
#17 bridges/CdactionBridge.php(53): {closure:/home/paul/projects/rss-bridge/index.php:26}()
#18 bridges/CdactionBridge.php(53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page was changed.