Skip to content

Conversation

@eatvector
Copy link
Contributor

@eatvector eatvector commented Jul 12, 2025

拉取/合并请求描述:(PR description)

修复线程在信号处理函数中,访问TLS数据时出现load page fault异常,关联#10501
[

为什么提交这份PR (why to submit this PR)

在rt-smart的riscv64架构中,当通过arch_thread_signal_enter从内核态切换到用户态信号处理程序时,未正确恢复线程指针(tp)寄存器。这会导致用户线程通过tp指针访问线程局部存储(TLS)时触发load page fault异常。

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@eatvector eatvector requested a review from BernardXiong as a code owner July 12, 2025 13:21
@github-actions github-actions bot added Arch: RISC-V BSP related with risc-v RT-Smart RT-Thread Smart related PR or issues component: lwp libcpu Component labels Jul 12, 2025
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: components

Path: components
Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/lwp/arch/risc-v/rv64/lwp_gcc.S

🏷️ Tag: lwp

Path: components/lwp
Reviewers: @xu18838022837

Changed Files (Click to expand)
  • components/lwp/arch/risc-v/rv64/lwp_gcc.S

🏷️ Tag: rvlibcpu

Path: libcpu/risc-v
Reviewers: @Yaochenger

Changed Files (Click to expand)
  • libcpu/risc-v/common64/stackframe.h

📊 Current Review Status (Last Updated: 2025-07-12 13:21 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@eatvector eatvector changed the title [lwp][rv64] restore tp register in arch_thread_signal_enter to fix us… [lwp][rv64] fix the load page fault occurring in the signal handler function Jul 17, 2025
@eatvector
Copy link
Contributor Author

@BernardXiong 请问大佬有空帮忙审核一下这个吗,改动很小👀

@Rbb666 Rbb666 merged commit e7a40ae into RT-Thread:master Jul 23, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v component: lwp Component libcpu RT-Smart RT-Thread Smart related PR or issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants