Skip to content

[DM/PCI] Update PCI #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2025
Merged

[DM/PCI] Update PCI #10622

merged 4 commits into from
Aug 25, 2025

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Aug 20, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

  1. Fixup the MSI info shuold free
  2. Fixup the bus-range probe
  3. Fixup the DWC PCI resource release
  4. Add SoC PCI Kconfig import

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions GitHub Actions
Copy link

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/include/drivers/pci_msi.h
  • components/drivers/pci/host/Kconfig
  • components/drivers/pci/host/dw/pcie-dw_host.c
  • components/drivers/pci/msi/irq.c
  • components/drivers/pci/msi/msi.c
  • components/drivers/pci/ofw.c

📊 Current Review Status (Last Updated: 2025-08-20 16:56 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@GuEe-GUI
Copy link
Contributor Author

@Maihuanyi

Maihuanyi
Maihuanyi reviewed Aug 25, 2025
View reviewed changes
components/drivers/pci/ofw.c
@@ -314,7 +314,10 @@ rt_err_t rt_pci_ofw_host_bridge_init(struct rt_ofw_node *dev_np,

if (rt_ofw_prop_read_u32_array_index(dev_np, "bus-range", 0, 2, host_bridge->bus_range) < 0)
{
return -RT_EIO;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要返回错误码了吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照别的平台的操作系统设备树规范来看，是允许在设备树未定义的情况下，设置总线范围默认值未 0~255，在实际树莓派 5 平台上也确实有这种情况，所以就不再返回错误，而是设定默认值。

@Maihuanyi
Copy link
Contributor

LGTM

@GuEe-GUI
Copy link
Contributor Author

@Rbb666

@Rbb666 Rbb666 merged commit af2c8ae into RT-Thread:master Aug 25, 2025
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

+1 more reviewer

@Maihuanyi Maihuanyi Maihuanyi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
component: drivers/pci component: drivers Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuEe-GUI @Maihuanyi @Rbb666