[dm][pin][pinctrl] Update for DM #11027
Conversation
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-09 23:14 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR adds Device Manager (DM) support for pin control subsystem with the following changes:
- New ARM PL061 GPIO driver for DM-based systems
- Single Pinctrl driver supporting TI and generic pinctrl-single bindings
- New
pin_gpio_requestAPI for GPIO pin configuration via pinctrl - Kconfig updates to ensure DM-related options are only available when DM is enabled
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| components/drivers/pinctrl/pinctrl-single.c | New pinctrl-single driver with support for TI SoCs and generic pinctrl configuration |
| components/drivers/pinctrl/SConscript | Add build support for pinctrl-single driver |
| components/drivers/pinctrl/Kconfig | Add configuration option for RT_PINCTRL_SINGLE driver |
| components/drivers/pin/pin-pl061.c | New ARM PL061 GPIO driver with interrupt support |
| components/drivers/pin/dev_pin_dm.h | Add declaration for new pin_gpio_request API |
| components/drivers/pin/dev_pin_dm.c | Implement pin_gpio_request function for pinctrl integration |
| components/drivers/pin/SConscript | Add build support for PL061 driver |
| components/drivers/pin/Kconfig | Add RT_PIN_PL061 config option and restrict DM Kconfig to DM mode |
| components/drivers/include/drivers/dev_pin.h | Add pin_ctrl_gpio_request callback to rt_pin_ops |
🟡 [PR Title/PR 标题]: Title could be more specific / 标题可以更具体
English: PR title "Update for DM" is somewhat vague. Based on modified files, a more specific title would be: [dm][pin][pinctrl] Add PL061 GPIO and single pinctrl drivers for DM
中文：PR 标题"Update for DM"有些模糊。基于修改的文件，更具体的标题应为：[dm][pin][pinctrl] Add PL061 GPIO and single pinctrl drivers for DM
🟢 [PR Description/PR 描述]: Description is adequate / 描述充分
English: The PR description adequately lists the changes and affected BSP (Spacemit K1). Well structured with clear points.
中文：PR 描述充分列出了更改和受影响的 BSP（Spacemit K1）。结构清晰，要点明确。
Some GPIO should apply GPIO mode by pinctrl, add `pin_ctrl_gpio_request` for GPIO driver to apply it auto. Signed-off-by: GuEe-GUI <[email protected]>
Signed-off-by: GuEe-GUI <[email protected]>
1. ARM PL061 GPIO 2. Single Pinctrl Signed-off-by: GuEe-GUI <[email protected]>
|
@Rbb666 AI相关要求已修改 |
2 participants
拉取/合并请求描述：(PR description)
[
Spacemit K1
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up