[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

wdfk-prog · 2024-06-30T13:37:39Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

[components][SPI][spi-bit-ops]修复可能的异常操作]
[components][drivers][spi]重命名spi.h为spi_core.h
[STM32][SPI]根据频率计算收发超时时间
[STM32][SPI]移除内部编写的延时函数使用统一延时接口

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

BSP: STM32H750

.config: wdfk-prog/ART-PI@c8a69a5

action:

spi.h 修改为spi_core.h 防止bsp中包含同样名称.h导致编译异常

[[STM32][SPI]根据频率计算收发超时时间] 编写测试 W25Q128 FLASH正常读取

模拟SPI编译通过,未进行实际测试;

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

components/drivers/include/drivers/spi_core.h

* 移除初始化时未进行引脚初始化就进行引脚设置可能导致的异常 * CS引脚配置判断完善 * xfer返回值优化

mysterywolf · 2024-07-11T16:48:51Z

我觉得1、2commit没有问题，3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

wdfk-prog · 2024-07-12T02:55:36Z

我觉得1、2commit没有问题，3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

行;第3个commit的话,最少也得把这个头文件宏改掉,不然肯定有问题

#ifndef __SPI_H__
#define __SPI_H__
#endif

wdfk-prog · 2024-07-12T03:14:39Z

我觉得1、2commit没有问题，3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

第4个的话,应该来说SPI没有啥速率规定;现在仅用了一个常规条件下能够接收的超时时间;
换成计算的方式会更好

mysterywolf · 2024-08-13T08:33:35Z

第3个commit的话,最少也得把这个头文件宏改掉,不然肯定有问题

#9301

mysterywolf · 2024-09-13T21:41:20Z

#9420

mysterywolf · 2024-10-05T05:27:02Z

还剩下最后一个commit没有合入 [STM32][SPI]根据频率计算收发超时时间是否直接让用户通过config配置好超时时间更加简单粗暴而且十分明了呢？

wdfk-prog · 2024-10-06T01:30:24Z

还剩下最后一个commit没有合入 [STM32][SPI]根据频率计算收发超时时间是否直接让用户通过config配置好超时时间更加简单粗暴而且十分明了呢？

用户咋知道多长超时是合理的呢?合理的话还是得计算.

…meout calculation

github-actions · 2025-09-22T03:39:07Z

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)

bsp/stm32/libraries/HAL_Drivers/drivers/drv_soft_spi.c
bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c

🏷️ Tag: bsp_wch

Reviewers: @Maihuanyi

Changed Files (Click to expand)

bsp/wch/arm/Libraries/ch32_drivers/drv_spi_ch32f10x.c
bsp/wch/arm/Libraries/ch32_drivers/drv_spi_ch32f20x.c
bsp/wch/risc-v/Libraries/ch56x_drivers/ch56x_spi.c
bsp/wch/risc-v/ch569w-evt/applications/test.c

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)

components/drivers/include/drivers/spi_core.h
components/drivers/include/rtdevice.h
components/drivers/spi/enc28j60.c
components/drivers/spi/enc28j60.h
components/drivers/spi/qspi_core.c
components/drivers/spi/spi-bit-ops.c
components/drivers/spi/spi-bit-ops.h
components/drivers/spi/spi_core.c
components/drivers/spi/spi_dev.c
components/drivers/spi/spi_flash.h
components/drivers/spi/spi_flash_sfud.c
components/drivers/spi/spi_flash_sfud.h

🏷️ Tag: components_driver_spi

Reviewers: @Liang1795 @wdfk-prog

Changed Files (Click to expand)

components/drivers/spi/enc28j60.c
components/drivers/spi/enc28j60.h
components/drivers/spi/qspi_core.c
components/drivers/spi/spi-bit-ops.c
components/drivers/spi/spi-bit-ops.h
components/drivers/spi/spi_core.c
components/drivers/spi/spi_dev.c
components/drivers/spi/spi_flash.h
components/drivers/spi/spi_flash_sfud.c
components/drivers/spi/spi_flash_sfud.h

📊 Current Review Status (Last Updated: 2025-09-22 11:39 CST)

⌛ @Liang1795 Pending Review
⌛ @Maihuanyi Pending Review
⌛ @hamburger-os Pending Review
⌛ @wdfk-prog Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

wdfk-prog force-pushed the drv_spi branch from 84250eb to e42691b Compare July 1, 2024 01:04

Rbb666 reviewed Jul 1, 2024

View reviewed changes

components/drivers/include/drivers/spi_core.h Outdated Show resolved Hide resolved

Rbb666 reviewed Jul 1, 2024

View reviewed changes

components/drivers/include/drivers/spi_core.h Show resolved Hide resolved

wdfk-prog force-pushed the drv_spi branch from e42691b to e94d7b1 Compare July 1, 2024 14:10

wdfk-prog added 4 commits July 2, 2024 09:27

[components][SPI][spi-bit-ops]修复可能的异常操作

64b57dc

* 移除初始化时未进行引脚初始化就进行引脚设置可能导致的异常 * CS引脚配置判断完善 * xfer返回值优化

[STM32][SPI]移除内部编写的延时函数使用统一延时接口

ec70a01

[components][drivers][spi]重命名spi.h为spi_core.h

1a6409c

[STM32][SPI]根据频率计算收发超时时间

11b6a59

wdfk-prog force-pushed the drv_spi branch from e94d7b1 to 11b6a59 Compare July 2, 2024 01:29

mysterywolf closed this Jul 4, 2024

mysterywolf reopened this Jul 4, 2024

mysterywolf marked this pull request as draft July 11, 2024 16:49

mysterywolf mentioned this pull request Jul 11, 2024

[components][SPI][spi-bit-ops]修复可能的异常操作 #9177

Merged

9 tasks

mysterywolf added the prototype label Sep 2, 2024

fix:[STM32][SPI]Refactor spixfer to fix DMA reception bug, correct ti…

d0859e7

…meout calculation

github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP BSP: Infineon BSP related with Infineon component: drivers/spi BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH Component labels Sep 22, 2025

github-actions bot added the component: drivers label Sep 22, 2025

wdfk-prog mentioned this pull request Sep 22, 2025

[Bug] STM32的SPI驱动在DMA 全双工模式下 recv_buf 数据未更新的问题 #10716

Closed

wdfk-prog marked this pull request as ready for review September 30, 2025 00:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

Uh oh!

wdfk-prog commented Jun 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mysterywolf commented Jul 11, 2024 •

edited

Loading

Uh oh!

wdfk-prog commented Jul 12, 2024

Uh oh!

wdfk-prog commented Jul 12, 2024

Uh oh!

mysterywolf commented Aug 13, 2024 •

edited

Loading

Uh oh!

mysterywolf commented Sep 13, 2024

Uh oh!

mysterywolf commented Oct 5, 2024 •

edited

Loading

Uh oh!

wdfk-prog commented Oct 6, 2024

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

Uh oh!

[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

Are you sure you want to change the base?

[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

Uh oh!

Conversation

wdfk-prog commented Jun 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

spi.h 修改为spi_core.h 防止bsp中包含同样名称.h导致编译异常

[[STM32][SPI]根据频率计算收发超时时间] 编写测试 W25Q128 FLASH正常 读取

模拟SPI编译通过,未进行实际测试;

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

Uh oh!

Uh oh!

mysterywolf commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wdfk-prog commented Jul 12, 2024

Uh oh!

wdfk-prog commented Jul 12, 2024

Uh oh!

mysterywolf commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mysterywolf commented Sep 13, 2024

Uh oh!

mysterywolf commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wdfk-prog commented Oct 6, 2024

Uh oh!

github-actions bot commented Sep 22, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

🏷️ Tag: bsp_wch

🏷️ Tag: components

🏷️ Tag: components_driver_spi

📊 Current Review Status (Last Updated: 2025-09-22 11:39 CST)

📝 Review Instructions

Uh oh!

Uh oh!

wdfk-prog commented Jun 30, 2024 •

edited

Loading

[[STM32][SPI]根据频率计算收发超时时间] 编写测试 W25Q128 FLASH正常读取

mysterywolf commented Jul 11, 2024 •

edited

Loading

mysterywolf commented Aug 13, 2024 •

edited

Loading

mysterywolf commented Oct 5, 2024 •

edited

Loading