Skip to content

Conversation

0Bitbiscuits
Copy link
Contributor

@0Bitbiscuits 0Bitbiscuits commented Dec 22, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

支持mlibc与rtthread的编译
目前仅支持编译rt-thread, 编译rt-smart由后续进一步提交

你的解决方案是什么 (what is your solution)

添加相关头文件

请提供验证的bsp和config (provide the config and bsp)

  • BSP:qemu-vexpress-a9
  • .config: PKG_USING_MLIBC
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [*] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ *] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [* ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [* ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [* ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [* ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [ *] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [* ] 代码是高质量的 Code in this PR is of high quality
  • [* ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@BernardXiong
Copy link
Member

请完善commit message,thanks。

@0Bitbiscuits 0Bitbiscuits force-pushed the mlibc branch 3 times, most recently from fa7adfd to 2c4fb34 Compare December 30, 2024 14:06
@BernardXiong
Copy link
Member

可否加入rt-smart上使用mlibc的ci看护?也就是对于qemu-aarch64/qemu-riscv64上加入smart的选项,并使用mlibc,来做ci持续集成。

@BernardXiong BernardXiong added 🎯 Focus Should focus on this issue/discussion/pr RT-Smart RT-Thread Smart related PR or issues labels Jan 1, 2025
@0Bitbiscuits
Copy link
Contributor Author

可否加入rt-smart上使用mlibc的ci看护?也就是对于qemu-aarch64/qemu-riscv64上加入smart的选项,并使用mlibc,来做ci持续集成。

可以,我尝试一下

@Rbb666 Rbb666 marked this pull request as draft February 9, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve component: lwp Component 🎯 Focus Should focus on this issue/discussion/pr RT-Smart RT-Thread Smart related PR or issues testcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants