Fixed a bug where changing the password of the :user factory would cause the Cucumber specs to break.#30
Open
bbugh wants to merge 1 commit intoRailsApps:masterfrom
bbugh:master
Open
Fixed a bug where changing the password of the :user factory would cause the Cucumber specs to break.#30bbugh wants to merge 1 commit intoRailsApps:masterfrom bbugh:master
bbugh wants to merge 1 commit intoRailsApps:masterfrom
bbugh:master
Conversation
…use the Cucumber specs to break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the default
:userpassword for thefactories/users.rbwill causes errors, because theuser_steps.rbdefinitions uses it's own default password that only by coincidence is the same as the user factory. This will cause the Cucumber specs to fail.I changed it to simply load the
@visitorhash as options when creating a user. It seems to make more sense anyway since the visitor is used elsewhere. You could also write out the fullpassword: @visitor[:password], password_confirmation: @visitor[:password_confirmation]but that seems clunkier.A minor bug, but it cost me a few hours of frustration, so hopefully this will save someone else the trouble.