Skip to content

PHP 8.4 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PHP 8.4 #225

wants to merge 7 commits into from

Conversation

makomweb
Copy link

  • uses Rector to bring the code base up to being PHP 8.4 compliant
  • fixes a bug with an optional default scheduler being null

@bartvanhoutte
Copy link
Contributor

Can you double check the following please?

PHP Deprecated: Return type of Rx\Scheduler\InternalPriorityQueue::insert($item, $priority) should either be compatible with SplPriorityQueue::insert(mixed $value, mixed $priority): true, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

@makomweb
Copy link
Author

@bartvanhoutte What do I have to do in order to see this deprecation message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makomweb @bartvanhoutte