This repository was archived by the owner on Oct 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
feat(route getting started page): getting started page #43
Open
arat3091
wants to merge
74
commits into
ReactiveX:master
Choose a base branch
from
arat3091:arat3091/pr33-getting-started-guide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
c95a00d
added stubs for all operators
btroncone 11fc524
updated operator formatting
btroncone 363484d
update lint settings
btroncone 242b28d
correctly type doc objects
btroncone 05fc934
styling and grouping updates
btroncone 62cb886
basic operator outline
btroncone 38f2c27
operator styling updates
btroncone ba8fbbf
sidenav navigation tweaks
btroncone e886d00
operator toc start
btroncone 0cbec6f
operator styling progress
btroncone 0f25ced
styling updates
btroncone 90577f1
updated to material beta.12
btroncone a6985eb
operator navigation update
btroncone bfb948e
added highlight.js
btroncone acea05d
operator routing update
btroncone a43f86d
operator formatting update
btroncone 5bc28e2
styling and formatting updates
btroncone bf4bd05
media helpers
btroncone 94d4188
filling in info and styling updates
btroncone 700b247
fixed source url
btroncone 363f68f
merge upstream
btroncone f365292
update routing to module
btroncone 317449b
split up operator components
btroncone 2eaa156
added walkthrough
btroncone 6c7f2c4
update active color
btroncone 68a52b1
added copy + operator styling updates
btroncone a73d3b6
operator display tweaks
btroncone cdd9152
styling + quick link updates
btroncone df94a2c
Merge branch 'master' into operator-section
btroncone 0bf3e2b
removed unused routes
btroncone 0e681a0
added jsbin iframe for examples
btroncone a8311b7
rx-marbles integration + responsive updates
btroncone 2b9614f
merge master
btroncone a912ee9
header styling update
btroncone a9ae9c8
added initial tests for operators component
btroncone 4ea7a07
feat(route getting started page): getting started page
fd8a605
fix(removing test): removing test
988b277
testing out the addition of commitizen
2c533f9
feat($compile): add commitizen wizard for easy commit message creation
eef6095
docs(README.md): add references to external content
1b93013
docs(Remove extra nonexistent links): Remove links to docs that do no…
6b8a324
docs(Readme.md): Add license line
c63d3db
docs(Readme.md): Update badge urls
abd2cf4
feat(package.json, readme.md): add engines object to package.json
3faf503
docs(Remove all the docs and converage references): Removed reference…
84e507c
docs(CONTRIBUTING.md and README.md): Improve Readme and Contributing …
7cb3669
docs(CONTRIBUTING.md): Changed reference to rxjs docs
aec9e36
Merge pull request #44 from knittingcodemonkey/addToReadme
ladyleet 8a18c13
docs(CONTRIBUTING.md, README.md): Add instructions regarding commit s…
b6344d9
Merge pull request #46 from knittingcodemonkey/commitScriptDocumentation
kwonoj c1bfa0b
fix(link to external docs): Review comments
5ba0dc8
feat(route getting started page): getting started page
ca398e1
fix(removing test): removing test
209b790
fix(link to external docs): Review comments
56a6d11
Merge branch 'arat3091/pr33-getting-started-guide' of https://github.…
d22320a
Merge remote-tracking branch 'upstream/master' into operator-section
btroncone f454d49
style(operators): split description between lines to fix linting problem
btroncone 73a724e
Merge pull request #34 from btroncone/operator-section
ladyleet 99b382b
chore(tooling): Add prettier, lint-staged and precommit hook for tooling
ashwin-sureshkumar b78856e
Merge pull request #49 from ashwin-sureshkumar/issue-45
ladyleet 35fdf0b
chore(danger): fix dangerfile
kwonoj c45f65c
Merge pull request #59 from kwonoj/fix-lodash
kwonoj 4c6ce9e
chore(danger): update rules
kwonoj 626fa7d
chore(travis): update build coverage config
kwonoj 86bdde6
Merge pull request #60 from kwonoj/chore-coverage
kwonoj 82b830a
feat(route getting started page): getting started page
fba476d
fix(removing test): removing test
2726b16
fix(link to external docs): Review comments
e3992c9
fix(merge from upstream)
a025699
fix(removing test): removing test
d9bcd7e
Merge branch 'arat3091/pr33-getting-started-guide' of https://github.…
47bf72c
fix(adding formatting)
d0e1c08
fix(getting started guide): getting started guide
5e153c8
fix(guide): guide for starters
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
src/app/getting-started-guide/getting-started-guide.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This is getting started guide. We can go through the below link for the introduction of Rxjs. | ||
<div> | ||
<a (click)='goToUrl()' [routerLink]="">Introduction to Reactive programming by Andre Staltz</a> | ||
</div> |
Empty file.
20 changes: 20 additions & 0 deletions
20
src/app/getting-started-guide/getting-started-guide.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { DOCUMENT } from '@angular/platform-browser'; | ||
import { Component, Inject, OnInit } from '@angular/core'; | ||
|
||
@Component({ | ||
selector: 'app-getting-started-guide', | ||
templateUrl: './getting-started-guide.component.html', | ||
styleUrls: ['./getting-started-guide.component.scss'] | ||
}) | ||
export class GettingStartedGuideComponent implements OnInit { | ||
|
||
constructor(@Inject(DOCUMENT) private document: any) { } | ||
|
||
ngOnInit() { | ||
} | ||
|
||
goToUrl() { | ||
|
||
this.document.location.href = 'https://gist.github.com/staltz/868e7e9bc2a7b8c1f754'; | ||
|
||
} | ||
|
||
} |
10 changes: 10 additions & 0 deletions
10
src/app/getting-started-guide/getting-started-guide.module.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { NgModule } from '@angular/core'; | ||
|
||
import { GettingStartedGuideComponent } from './getting-started-guide.component'; | ||
import { routing } from './getting-started-guide.routing'; | ||
|
||
@NgModule({ | ||
imports: [routing], | ||
declarations: [GettingStartedGuideComponent] | ||
}) | ||
export class GettingStartedGuideModule { } |
11 changes: 11 additions & 0 deletions
11
src/app/getting-started-guide/getting-started-guide.routing.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { ModuleWithProviders } from '@angular/core'; | ||
import { RouterModule, Routes } from '@angular/router'; | ||
|
||
import { GettingStartedGuideComponent } from './getting-started-guide.component'; | ||
|
||
const routes: Routes = [ | ||
{ path: '', component: GettingStartedGuideComponent } | ||
]; | ||
|
||
export const routing: ModuleWithProviders = RouterModule.forChild(routes); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should like to the "getting started" guide in the current docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this a plain
href
with target_blank
? I think it would be better to open in new tab rather than leaving docs for external links.