refactor: popup handling and animation stability #53
Conversation
TwrblxDevs
commented
Nov 3, 2025
TwrblxDevs
commented
- Added nil-check before accessing currentTheme to prevent potential runtime errors.
- Fixed lingering reference issue by explicitly clearing currentPopup/currentCustomPopup before new assignment.
- Improved InputBegan safety by adding UserInputType check to ignore non-keyboard events.
- Adjusted background transition to use linear damping for smoother fade effect.
- Ensured consistent ZIndex usage across nested elements for better layering stability.
- Added nil-check before accessing currentTheme to prevent potential runtime errors. - Fixed lingering reference issue by explicitly clearing currentPopup/currentCustomPopup before new assignment. - Improved InputBegan safety by adding UserInputType check to ignore non-keyboard events. - Adjusted background transition to use linear damping for smoother fade effect. - Ensured consistent ZIndex usage across nested elements for better layering stability.
|
Forgot to add: General readability and structure improvements (no logic redesign, no variable renaming). |
|
Just some QOL Stuff basically just improving this script and making it easier to read |
parker02311
left a comment
parker02311
left a comment
There was a problem hiding this comment.
Thank you for the pull request! I have done a quick review before I must head to work. Please take a look over and feel free to ask about any questions and I will get back to you ASAP!
parker02311
added
enchancement
parker02311
changed the title
|
Additionally please update your commit messages to follow https://www.conventionalcommits.org/en/v1.0.0/ This can be done using git on your end and force-pushing the commits with new messages tbf I should have added a contributing guide but I also didn't expect anyone to actual contribute |
| } | ||
| local popup = {} :: popup | ||
|
|
||
| local function getColors(valueType: string, theme): {BackgroundColor: Color3, TextColor: Color3, ShadowColor: Color3, ButtonGlowColor: Color3} |
There was a problem hiding this comment.
theme should be typed, using RedonUI.theme.theme as the type
| local mt = getmetatable(scope :: any) | ||
| if typeof(mt) == "table" and mt._FUSION_POISONED then | ||
| return | ||
| end |
| local mt = getmetatable(scope :: any) | ||
| if typeof(mt) == "table" and mt._FUSION_POISONED then | ||
| return | ||
| end |
There was a problem hiding this comment.
Whoops probably overlooked this on accident as well for the other one too
|
also the commit would be |
My bad github apparently made this title |
2 participants
