finished other meet the team screen #19
Conversation
Deploying rp-web-hype with
|
| Latest commit: |
96f62b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a10d6c43.rp-web-hype.pages.dev |
| Branch Preview URL: | https://write2vaniramesh-meettheteam-3u9p.rp-web-hype.pages.dev |
Deploying rp-web-admin with
|
| Latest commit: |
96f62b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb4bf6f8.rp-web-admin.pages.dev |
| Branch Preview URL: | https://write2vaniramesh-meettheteam-jqkw.rp-web-admin.pages.dev |
There was a problem hiding this comment.
Foldable component: This is awesome! It feels especially slick on my phone/touchscreens. I think there is a little bit of awkwardness to dragging the faq box with a mouse and especially with a trackpad. Maybe there should be an alternate interaction that also opens the faq page?
Meet the team: I'm really excited to see what this page looks like when its filled in with all of the staff photos! Similarly to my comment with the carousel, it might be necessary to make the photos a bit larger but overall this design is great
| overflow="hidden" | ||
| bg={bgColor} | ||
| animate={{ | ||
| boxShadow: isFolded |
There was a problem hiding this comment.
Can we adjust this box shadow to be less(?) visible when the faq is open. Right now it feels a bit boxy.
| itemWidth: "180px", | ||
| itemHeight: "120px", |
There was a problem hiding this comment.
It might make sense to make the images a bit bigger, especially if they are going to be group photos
There was a problem hiding this comment.
made that change!
apps/info/src/routes/Team.tsx
Outdated
| children: React.ReactNode; | ||
| sectionBg?: string; | ||
| }> = ({ title, children, sectionBg = "white" }) => ( | ||
| <Box py={spacing} bg={sectionBg}> |
There was a problem hiding this comment.
I love these section headers that scroll with the top of the screen! I'm not sure if I'm a fan of the paddingY here though. In my opinion it looks better with no vertical padding
There was a problem hiding this comment.
sounds good! took it off
No description provided.