You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes it easy to install this package and use an older version of chromium so that things like #17 work, but it's not very nice having to set the PUPPETEER_CHROMIUM_REVISION=526987 on install as well as in the package.json - not really sure if there is a better way.
To be honest, this might not be needed if someone can figure out why transform:rotate doesn't work, but I'll leave it here in case it helps.
Hey, I like this PR but is the export PUPPETEER_CHROMIUM_REVISION=526987 mandatory ?
I am trying to make the installation/setup as simple as possible, so that even people with no clue what NPM is can use it.
I'd rather keep the installation instructions clear, and in the future always keep examples and code aligned on the most recent pupetteer and chromium (as I expect improvements).
Then there would be a special section in the docs explaining that for people wanting reliability they can use export PUPPETEER_CHROMIUM_REVISION=526987 (in docker, travis, etc.).
Yea I'm not overly keen on the export PUPPETEER_CHROMIUM_REVISION=526987 either.
I'll have a look and see if there's a better way to use the default value from puppeteer unless that ENV is set.
cross-env, shelljs / shx could be somehow helpful to give some ideas for possible solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy to install this package and use an older version of chromium so that things like #17 work, but it's not very nice having to set the PUPPETEER_CHROMIUM_REVISION=526987 on install as well as in the package.json - not really sure if there is a better way.
To be honest, this might not be needed if someone can figure out why transform:rotate doesn't work, but I'll leave it here in case it helps.
Related to #22