Add permeability and solubility properties for 1020, 1050, 1095 carbon#310
Open
WeaverC20 wants to merge 3 commits intoRemDelaporteMathurin:mainfrom
Open
Add permeability and solubility properties for 1020, 1050, 1095 carbon#310WeaverC20 wants to merge 3 commits intoRemDelaporteMathurin:mainfrom
WeaverC20 wants to merge 3 commits intoRemDelaporteMathurin:mainfrom
Conversation
RemDelaporteMathurin
requested changes
Apr 2, 2026
Owner
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Thanks @WeaverC20 could you maybe attach the WPD .tar files?
First pass of comments
Comment on lines
+7
to
+16
| bibsource = """@techreport{san_marchi_technical_2012, | ||
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | ||
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | ||
| number = {SAND2012-7321}, | ||
| doi = {10.2172/1055634}, | ||
| institution = {Sandia National Laboratories}, | ||
| year = {2012}, | ||
| month = {sep}, | ||
| pages = {1100--23}, | ||
| }""" |
There was a problem hiding this comment.
If you already added this to the .bib file then we don't need that here
Suggested change
| bibsource = """@techreport{san_marchi_technical_2012, | |
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | |
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | |
| number = {SAND2012-7321}, | |
| doi = {10.2172/1055634}, | |
| institution = {Sandia National Laboratories}, | |
| year = {2012}, | |
| month = {sep}, | |
| pages = {1100--23}, | |
| }""" |
Comment on lines
+7
to
+16
| bibsource = """@techreport{san_marchi_technical_2012, | ||
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | ||
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | ||
| number = {SAND2012-7321}, | ||
| doi = {10.2172/1055634}, | ||
| institution = {Sandia National Laboratories}, | ||
| year = {2012}, | ||
| month = {sep}, | ||
| pages = {1100--23}, | ||
| }""" |
There was a problem hiding this comment.
Suggested change
| bibsource = """@techreport{san_marchi_technical_2012, | |
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | |
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | |
| number = {SAND2012-7321}, | |
| doi = {10.2172/1055634}, | |
| institution = {Sandia National Laboratories}, | |
| year = {2012}, | |
| month = {sep}, | |
| pages = {1100--23}, | |
| }""" |
There was a problem hiding this comment.
We don't need this if it's already in the bib file
Comment on lines
+7
to
+16
| bibsource = """@techreport{san_marchi_technical_2012, | ||
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | ||
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | ||
| number = {SAND2012-7321}, | ||
| doi = {10.2172/1055634}, | ||
| institution = {Sandia National Laboratories}, | ||
| year = {2012}, | ||
| month = {sep}, | ||
| pages = {1100--23}, | ||
| }""" |
There was a problem hiding this comment.
Suggested change
| bibsource = """@techreport{san_marchi_technical_2012, | |
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | |
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | |
| number = {SAND2012-7321}, | |
| doi = {10.2172/1055634}, | |
| institution = {Sandia National Laboratories}, | |
| year = {2012}, | |
| month = {sep}, | |
| pages = {1100--23}, | |
| }""" |
Comment on lines
+7
to
+16
| bibsource = """@techreport{san_marchi_technical_2012, | ||
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | ||
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | ||
| number = {SAND2012-7321}, | ||
| doi = {10.2172/1055634}, | ||
| institution = {Sandia National Laboratories}, | ||
| year = {2012}, | ||
| month = {sep}, | ||
| pages = {1100--23}, | ||
| }""" |
There was a problem hiding this comment.
Suggested change
| bibsource = """@techreport{san_marchi_technical_2012, | |
| title = {Technical Reference for Hydrogen Compatibility of Materials}, | |
| author = {San Marchi, Christopher W. and Somerday, Brian P.}, | |
| number = {SAND2012-7321}, | |
| doi = {10.2172/1055634}, | |
| institution = {Sandia National Laboratories}, | |
| year = {2012}, | |
| month = {sep}, | |
| pages = {1100--23}, | |
| }""" |
h_transport_materials/_version.py
Outdated
There was a problem hiding this comment.
This file should not be tracked in version control (see the comment at the top of the file). Please remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added plot digitizer results for 1020, 1050, 1095 carbon steels