-
Notifications
You must be signed in to change notification settings - Fork 20
added envrionment variable to simplify switching schemas in UI #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bendhouseart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new environment variable, VUE_APP_REPROSCHEMA_GITHUB_SRC, to allow for easier switching of schema sources in the UI. This change enables developers to load different schemas by simply setting an environment variable, while maintaining the default demo protocol as a fallback. This enhances the flexibility of the application's configuration, particularly for development and testing scenarios where different schemas might be required.
Highlights
- Flexible Schema Loading: The application's schema source can now be dynamically configured via the VUE_APP_REPROSCHEMA_GITHUB_SRC environment variable, providing greater flexibility for development and testing.
- Dependency Updates: The package.json file has been updated to include dotenv for environment variable management and to adjust the placement of @adapttive/vue-markdown and @babel/eslint-parser dependencies.
- Configuration Logic: The src/config.js file now prioritizes the VUE_APP_REPROSCHEMA_GITHUB_SRC environment variable for the githubSrc property, falling back to the default demo protocol if the variable is not set.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful feature by allowing the schema source to be configured via an environment variable, which improves flexibility for development and deployment. The implementation is straightforward and correct.
My main feedback is regarding a console.log
statement added for debugging, which should be removed to avoid logging to the console in a production environment.
Also, there's a small typo in the pull request title ('envrionment' should be 'environment').
src/config.js
Outdated
|
||
console.log(`Loading schema from VUE_APP_REPROSCHEMA_GITHUB_SRC: ${process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with gemini-code-assist here. Make those two corrections, and you're good to go IMO! I saw your demo this morning to load any schema file from the backend in this more flexible way, and I was happy to see it working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the confirmation, @ericearl. @bendhouseart, please remove the console.log
statement as suggested to finalize this change. Once that's done, this thread can be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bendhouseart i agree with this one
"bootstrap-vue": "^2.23.1", | ||
"bowser": "^2.11.0", | ||
"core-js": "^3.36.1", | ||
"dotenv": "^17.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you introduced the dotenv
dependency. Is that what's necessary in this PR to make the process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC
work? If not, I would remove it for the sake of a cleaner PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-check mine and gemini-code-assist's comments, then I'm fine approving this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me except the console.log
Keeps the default demo protocol as default but allows side loading of any schema by exporting it's uri to the
VUE_APP_REPROSCHEMA_GITHUB_SRC
environment variable.