Skip to content

fix: Add issued date and status to request insertion in webhook#38

Merged
aimensahnoun merged 1 commit intomainfrom
37-easyinvoice---fix-recurring-invoice-duplicate-status
Mar 18, 2025
Merged

fix: Add issued date and status to request insertion in webhook#38
aimensahnoun merged 1 commit intomainfrom
37-easyinvoice---fix-recurring-invoice-duplicate-status

Conversation

@aimensahnoun
Copy link
Copy Markdown
Member

@aimensahnoun aimensahnoun commented Mar 17, 2025

  • Fix the status for duplicate invoices.

Summary by CodeRabbit

  • New Features

    • API now assigns a pending status to new requests, improving tracking.
  • Chores

    • Enhanced consistency in recording submission timestamps for reliable request handling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 17, 2025

Walkthrough

The changes update the POST function in the src/app/api/webhook/route.ts file. The code now consistently sets the issuedDate field with now.toISOString() and introduces a new field status with the value "pending" when inserting a new request entry. The overall logic flow remains unchanged.

Changes

File Change Summary
src/app/api/webhook/route.ts Updated the POST function to use now.toISOString() consistently for issuedDate and added a new status: "pending" field to the data insertion.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WebhookRoute
    participant DB as RequestTable

    Client->>WebhookRoute: POST request with payload
    WebhookRoute->>DB: Insert data (issuedDate = now.toISOString(), status = "pending")
    DB-->>WebhookRoute: Confirmation/Response
    WebhookRoute-->>Client: Return response
Loading

Suggested reviewers

  • MantisClone

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34a08b2 and a95f28a.

📒 Files selected for processing (1)
  • src/app/api/webhook/route.ts (1 hunks)
🔇 Additional comments (3)
src/app/api/webhook/route.ts (3)

97-97: LGTM: Setting issue date consistently.

The addition of issuedDate: now.toISOString() ensures that the new recurring request has its issue date properly set to the current date in ISO format. This is consistent with how dates are handled throughout the codebase.


101-101: Good addition of status field.

Adding status: "pending" to new recurring requests correctly addresses the PR objective of fixing the status for duplicate invoices. This ensures that all recurring requests start in a consistent state before they're processed further, matching the pattern used in the payment confirmation handler at line 36.


94-102:

Details

✅ Verification successful

Verify database schema requirements.

The changes look good - adding both issuedDate and status fields to recurring requests is an appropriate fix. Just verify that the status field is properly defined in the requestTable schema with appropriate constraints and default values if needed.


🏁 Script executed:

#!/bin/bash
# Check the database schema definition for the requestTable
cat $(fd -t f -e ts "schema" --exec grep -l "requestTable" {})
# Specifically look for status field definition
fd -t f -e ts "schema" --exec grep -A 10 "status" {} | grep -B 2 -A 2 "status"

Length of output: 4212


Database Schema Verified – No Further Changes Required

The changes to add both issuedDate and status fields to recurring requests are appropriate. The schema definition in src/server/db/schema.ts confirms that:

  • The status field is defined as text().notNull(), ensuring that a value must always be provided.
  • Although no default value is configured in the schema, the insertion code explicitly sets status to "pending", which fulfills the requirement.

No additional modifications are needed in the schema. Please ensure that any new requests always supply a valid status value if skipping the explicit insertion is a potential scenario.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aimensahnoun aimensahnoun merged commit a61f0e1 into main Mar 18, 2025
5 checks passed
@aimensahnoun aimensahnoun deleted the 37-easyinvoice---fix-recurring-invoice-duplicate-status branch March 18, 2025 02:45
@MantisClone MantisClone linked an issue Mar 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EasyInvoice - Fix recurring invoice duplicate status

2 participants