Open
Conversation
Step to reproduce: ``` [USB] chameleon --> hf mf esave -f test.bin API request fail, param error ``` Commit d95112f change NETDATA_MAX_DATA_LENGTH from 512 to 4096, this increase max block count to 256, while [cmd_processor_mf1_read_emu_block_data][1] hardcode max block count to 32 [1]: https://github.com/RfidResearchGroup/ChameleonUltra/blob/b108c84af9b473c840ddcae6f769502adb6c5aa5/firmware/application/src/app_cmd.c#L1088
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit 9d483cdFirmwareClient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step to reproduce:
Commit d95112f change NETDATA_MAX_DATA_LENGTH from 512 to 4096, this increase max block count to 256, while cmd_processor_mf1_read_emu_block_data hardcode max block count to 32