Fix Japanese translations for clarity and accuracy#140
Conversation
📝 WalkthroughWalkthroughA single YAML file containing Japanese translations underwent updates to improve furigana readings, normalize spacing, correct punctuation, and add previously missing translation content for specific classical Chinese phrases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit b9a4b18): https://izuminokami-kanesada--pr140-rindrics-patch-1-0cjl61ou.web.app (expires Thu, 12 Mar 2026 23:42:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4c4412227845b968bcb4c8b6996048cdd07fd6de |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contents/input/daxue/1/1.yaml`:
- Around line 12-28: In the YAML entries where text.original values like
"定而后能靜", "靜而后能安", "安而后能慮", and "慮而后能得" are paired with japanese translations,
remove the visible space immediately following the character "后" in each
corresponding text.japanese value (the entries currently showing "后 定まる有り", "后
能く静かに、", "后 能く安く、", "后 能く慮り、", "后 能く得(う)。") so the Japanese strings read without
the accidental gap (e.g., "后定まる有り", "后能く静かに、", etc.); update the text.japanese
fields for those text blocks to eliminate the extra space.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d2a3d357-b0e8-4beb-82e2-ca126ce93cdd
📒 Files selected for processing (1)
contents/input/daxue/1/1.yaml
| japanese: 止まることを知りて后 定まる有り、 | ||
| speaker: null | ||
| - text: | ||
| original: 定而后能靜 | ||
| japanese: 定まりて后に能く静かなり、 | ||
| japanese: 定まりて后 能く静かに、 | ||
| speaker: null | ||
| - text: | ||
| original: 靜而后能安 | ||
| japanese: 静かにして后に能く安く、 | ||
| japanese: 静かにして后 能く安く、 | ||
| speaker: null | ||
| - text: | ||
| original: 安而后能慮 | ||
| japanese: 安くして后に能く慮る、 | ||
| japanese: 安くして后 能く慮り、 | ||
| speaker: null | ||
| - text: | ||
| original: 慮而后能得 | ||
| japanese: 慮りて后能く得(う)。 | ||
| japanese: 慮りて后 能く得(う)。 |
There was a problem hiding this comment.
Remove the visible spaces after 后.
The spaces on Line 12, Line 16, Line 20, Line 24, and Line 28 will render as literal gaps in the Japanese text. They read like accidental formatting and are inconsistent with the rest of this file.
Suggested edit
- japanese: 止まることを知りて后 定まる有り、
+ japanese: 止まることを知りて后定まる有り、
- japanese: 定まりて后 能く静かに、
+ japanese: 定まりて后能く静かに、
- japanese: 静かにして后 能く安く、
+ japanese: 静かにして后能く安く、
- japanese: 安くして后 能く慮り、
+ japanese: 安くして后能く慮り、
- japanese: 慮りて后 能く得(う)。
+ japanese: 慮りて后能く得(う)。📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| japanese: 止まることを知りて后 定まる有り、 | |
| speaker: null | |
| - text: | |
| original: 定而后能靜 | |
| japanese: 定まりて后に能く静かなり、 | |
| japanese: 定まりて后 能く静かに、 | |
| speaker: null | |
| - text: | |
| original: 靜而后能安 | |
| japanese: 静かにして后に能く安く、 | |
| japanese: 静かにして后 能く安く、 | |
| speaker: null | |
| - text: | |
| original: 安而后能慮 | |
| japanese: 安くして后に能く慮る、 | |
| japanese: 安くして后 能く慮り、 | |
| speaker: null | |
| - text: | |
| original: 慮而后能得 | |
| japanese: 慮りて后能く得(う)。 | |
| japanese: 慮りて后 能く得(う)。 | |
| japanese: 止まることを知りて后定まる有り、 | |
| speaker: null | |
| - text: | |
| original: 定而后能靜 | |
| japanese: 定まりて后能く静かに、 | |
| speaker: null | |
| - text: | |
| original: 靜而后能安 | |
| japanese: 静かにして后能く安く、 | |
| speaker: null | |
| - text: | |
| original: 安而后能慮 | |
| japanese: 安くして后能く慮り、 | |
| speaker: null | |
| - text: | |
| original: 慮而后能得 | |
| japanese: 慮りて后能く得(う)。 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@contents/input/daxue/1/1.yaml` around lines 12 - 28, In the YAML entries
where text.original values like "定而后能靜", "靜而后能安", "安而后能慮", and "慮而后能得" are
paired with japanese translations, remove the visible space immediately
following the character "后" in each corresponding text.japanese value (the
entries currently showing "后 定まる有り", "后 能く静かに、", "后 能く安く、", "后 能く慮り、", "后
能く得(う)。") so the Japanese strings read without the accidental gap (e.g.,
"后定まる有り", "后能く静かに、", etc.); update the text.japanese fields for those text
blocks to eliminate the extra space.
Summary by CodeRabbit