Skip to content

Fix Japanese translations for clarity and accuracy#140

Merged
Rindrics merged 2 commits intomainfrom
Rindrics-patch-1
Mar 8, 2026
Merged

Fix Japanese translations for clarity and accuracy#140
Rindrics merged 2 commits intomainfrom
Rindrics-patch-1

Conversation

@Rindrics
Copy link
Copy Markdown
Owner

@Rindrics Rindrics commented Mar 5, 2026

Summary by CodeRabbit

  • Documentation
    • Updated Japanese translations with corrected character readings and improved spacing formatting.
    • Added missing Japanese translation for a previously untranslated phrase.
    • Standardized punctuation in Japanese text for consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

A single YAML file containing Japanese translations underwent updates to improve furigana readings, normalize spacing, correct punctuation, and add previously missing translation content for specific classical Chinese phrases.

Changes

Cohort / File(s) Summary
Japanese Translation Updates
contents/input/daxue/1/1.yaml
Adjusted furigana readings for characters, normalized spacing around specific characters, replaced punctuation marks with appropriate Japanese sentence endings, and added missing Japanese rendering for 知所先後 則近道矣.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Review effort 2/5

Poem

🐰 Whiskers twitching with delight,
Furigana now read just right,
Spacing flows and punctuation gleams,
Japanese translations reach their dreams!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updates to Japanese translations in a YAML file to improve clarity and accuracy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Rindrics-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Visit the preview URL for this PR (updated for commit b9a4b18):

https://izuminokami-kanesada--pr140-rindrics-patch-1-0cjl61ou.web.app

(expires Thu, 12 Mar 2026 23:42:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4c4412227845b968bcb4c8b6996048cdd07fd6de

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@contents/input/daxue/1/1.yaml`:
- Around line 12-28: In the YAML entries where text.original values like
"定而后能靜", "靜而后能安", "安而后能慮", and "慮而后能得" are paired with japanese translations,
remove the visible space immediately following the character "后" in each
corresponding text.japanese value (the entries currently showing "后 定まる有り", "后
能く静かに、", "后 能く安く、", "后 能く慮り、", "后 能く得(う)。") so the Japanese strings read without
the accidental gap (e.g., "后定まる有り", "后能く静かに、", etc.); update the text.japanese
fields for those text blocks to eliminate the extra space.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d2a3d357-b0e8-4beb-82e2-ca126ce93cdd

📥 Commits

Reviewing files that changed from the base of the PR and between 0cbd41f and b9a4b18.

📒 Files selected for processing (1)
  • contents/input/daxue/1/1.yaml

Comment on lines +12 to +28
japanese: 止まることを知りて后 定まる有り
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后に能く静かなり
japanese: 定まりて后 能く静かに
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后に能く安く
japanese: 静かにして后 能く安く
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后に能く慮る
japanese: 安くして后 能く慮り
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得(う)。
japanese: 慮りて后 能く得(う)。
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove the visible spaces after .

The spaces on Line 12, Line 16, Line 20, Line 24, and Line 28 will render as literal gaps in the Japanese text. They read like accidental formatting and are inconsistent with the rest of this file.

Suggested edit
-      japanese: 止まることを知りて后 定まる有り、
+      japanese: 止まることを知りて后定まる有り、
-      japanese: 定まりて后 能く静かに、
+      japanese: 定まりて后能く静かに、
-      japanese: 静かにして后 能く安く、
+      japanese: 静かにして后能く安く、
-      japanese: 安くして后 能く慮り、
+      japanese: 安くして后能く慮り、
-      japanese: 慮りて后 能く得(う)。
+      japanese: 慮りて后能く得(う)。
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
japanese: 止まることを知りて后 定まる有り、
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后に能く静かなり、
japanese: 定まりて后 能く静かに、
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后に能く安く、
japanese: 静かにして后 能く安く、
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后に能く慮る、
japanese: 安くして后 能く慮り、
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得(う)。
japanese: 慮りて后 能く得(う)。
japanese: 止まることを知りて后定まる有り、
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后能く静かに、
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后能く安く、
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后能く慮り、
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得(う)。
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@contents/input/daxue/1/1.yaml` around lines 12 - 28, In the YAML entries
where text.original values like "定而后能靜", "靜而后能安", "安而后能慮", and "慮而后能得" are
paired with japanese translations, remove the visible space immediately
following the character "后" in each corresponding text.japanese value (the
entries currently showing "后 定まる有り", "后 能く静かに、", "后 能く安く、", "后 能く慮り、", "后
能く得(う)。") so the Japanese strings read without the accidental gap (e.g.,
"后定まる有り", "后能く静かに、", etc.); update the text.japanese fields for those text
blocks to eliminate the extra space.

@Rindrics Rindrics merged commit 01b4fc7 into main Mar 8, 2026
6 checks passed
@Rindrics Rindrics deleted the Rindrics-patch-1 branch March 8, 2026 02:00
@Rindrics Rindrics mentioned this pull request Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant