Repository navigation
Show GTAD enabled/disabled badges from userAccountControl - #23
Merged
Merged
Conversation
Parse the ACCOUNTDISABLE bit on the GTAD LDAP userAccountControl attribute so the directory card shows a blue enabled badge when there are no Grouper groups, keeps group pills when provisioned, and shows a gray disabled badge (hiding groups) when the account is disabled. Co-authored-by: Kristaps Berzinch <kristaps@berzin.ch>
Only show enabled or disabled pills when userAccountControl is present and parseable. If it is unavailable, still render Grouper group badges when present, but do not infer an account status badge. Co-authored-by: Kristaps Berzinch <kristaps@berzin.ch>
Extract group badge HTML into groupBadges so enabled and missing-UAC paths reuse the same rendering instead of duplicating List.map. Co-authored-by: Kristaps Berzinch <kristaps@berzin.ch>
kberzinch
marked this pull request as ready for review
July 18, 2026 23:22
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse the GTAD LDAP
userAccountControlattribute on the frontend and update the GTAD directory card badges:enabledbadgedisabledbadge; Grouper groups are hiddenNo account(unchanged)Uses the AD
ACCOUNTDISABLEbit (0x2). Missing/unparseableuserAccountControlis treated as enabled so the card does not go blank.Changes
elm/Main.elm: addisGtadAccountDisabledandgtadGrouperGroupNameshelpers; update GTAD card badge rendering to match Keycloak-style enabled/disabled pillsNo backend changes —
/view/<id>/gtadalready returns all LDAP attributes viaattributes=["*"].Testing
elm-review,elm-format --validate, andnpm run build/build-debugpasskc21,kberzinch3,bg37,mbarulic6) require live GTAD (cloud uses an empty LDAP mock)