change escrow duration from 8 - 10 hrs

[hbdc-BtcFixesThis]

What does this PR do?

Fixes # #2234

This pr increases the maximum allowed escrow time from 8 to 10 hours

Checklist before merging

• Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

[KoalaSat]

Great you picked this one! Did you test the frontend? I think you will need some modifications on the Maker form

[hbdc-BtcFixesThis]

Thanks @KoalaSat, I updated the maker form and searched the codebase for any other references escrow duration. I would gladly test the frontend but I think I may need some help with test data to fill out an order; or just advice on how to test the change. I'm not very familiar with the flow but the duration is likely set after the deposit. I'm not sure what ways you go about bypassing the step for local testing. Thanks in advanced!

Oh and I found a small grammar issue when I opened one of the files to update so I included as part of the pr; hope thats ok. I can split it out into a separate pr if that's helpful.

[KoalaSat]

Ey @hbdc-BtcFixesThis sorry for taking this long to answer. I was about to merge but I realized it would great if we somehow reflect this in tests/test_trade_pipeline.py, specially by modifying

robosats/tests/utils/trade.py

Line 28 in 99905c0

"escrow_duration": 8700,

[hbdc-BtcFixesThis]

Ey @hbdc-BtcFixesThis sorry for taking this long to answer. I was about to merge but I realized it would great if we somehow reflect this in tests/test_trade_pipeline.py, specially by modifying

robosats/tests/utils/trade.py

Line 28 in 99905c0

"escrow_duration": 8700,

Thank you for taking a look @KoalaSat. My apologies for the delayed response. I added a test to check that the api responds appropriately when the escrow duration is out of the set bounds. I hope you are having an amazing start to your new year!

[fxrstor]

I don't think he meant to add a new test but rather change the value of escrow_duration. Is that correct? @KoalaSat

[KoalaSat]

I don't think he meant to add a new test but rather change the value of escrow_duration. Is that correct? @KoalaSat

Correct, but this also works, this way we are testing multiple values

[KoalaSat]

Hey @hbdc-BtcFixesThis thank you for your work this was recurrent feature request

Please accept a small tip for your work, share here a LN invoice with a long expiration date for 60,000 sats

[hbdc-BtcFixesThis]

Thank you @KoalaSat, I'm really glad I could help. I'd love to pick up another task to tackle next. It's a pleasure to work with good people on a project I truly believe in

bitcoin:BC1QJPX82HLXRNJERM4C5HF55KEG39EFD6XJCYWCJU?lightning=LNBC600U1P5K57NZPP5PEPQUJUSUEM4PN0PXGMTFC6XT75JJ5WQEYCAPFN0A6LAFG66356QDQ6G36HYCT5D9HKUGRXV4SHGATJV5CQZZSXQ9YN4QQSP5WY294GCE8Z83ZFDE3QF6CK6PMDDPCX3CJU8SME3A8D8SQVW5QKDS9QXPQYSGQ052V0CY7XMCL5K6SMFKZM7VNDRPTYWGWZPYCG2CMYTP5EUU4YQU3ZJMX900P22CCYSC0R63ZVG3RZCJ7H08CJUHUPAJYEX29JK35Q2QPXKRKWA&amount=0.0006&message=Duration%20feature

[KoalaSat]

@RobosatsDevFund

[RobosatsDevFund]

@hbdc-BtcFixesThis Our node is unable to connect with yours, could you please try again using a proxy wallet?