[feat]: Add famous replies #38
Conversation
Signed-off-by: brf153 <[email protected]>
| }; | ||
| } | ||
|
|
||
| private getAssociations(userId: string): RocketChatAssociationRecord[] { |
There was a problem hiding this comment.
Why not use src/storage/ReplyStorage.ts ?
| ]; | ||
| } | ||
|
|
||
| public async onInstall( |
There was a problem hiding this comment.
are we sure that this will run only once for each user ? we should run this once for each user who opens the app for the first time make sure we do it that way.
my feel this will run only for admin guy once the app is installed in the server research on this please.
| ): Promise<void> { | ||
| try { | ||
|
|
||
| const quickReplies: IReply[] = [ |
There was a problem hiding this comment.
please use method we already have for storing replies
| body: 'Thank you for reaching out. I will get back to you shortly.', | ||
| id: `${context.user.id}-${(Date.now() - 5).toString(36)}`, | ||
| }, | ||
| { |
There was a problem hiding this comment.
put this replies in some different file not here
|
@brf153 Let me know if you are not working on it now |
|
@VipinDevelops Apologies for the delay. I recently joined a startup and haven't been able to find time for this. I believe it would be best to reassign the task to someone else, who can refer to my PR for further progress. After doing some research, I realized that onInstall can be used, as it will set up the quick replies only once. However, instead of storing the quick replies with a specific admin ID in persistence, it would be better to use a common tag for the entire room. I believe this approach would be more effective. |
|
@VipinDevelops , Can I take it? |
3 participants
Issue(s)
closes #26
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Screencast.from.24-02-25.11.31.49.PM.IST.webm