Skip to content

Conversation

not-meet
Copy link
Contributor

Issue

A Pr made fixing the errors and issue of #37

#18

Acceptance Criteria fulfillment

  • Ai now have the last other users message to generate replies
  • If no user reply found , error notification is sent to user

###Testing and demo
Screencast from 2025-02-24 07-00-38.webm

Note - i found that quick replies do get other users message in a different pattern which is

const roomId = room.id; const roomMessages = await read .getRoomReader() .getMessages(roomId); const lastMessage = roomMessages.pop(); const Message = lastMessage?.text || lastMessage?.attachments?.[0]?.description || '';

this and i implemented that as well but in the time where there is no message of other user in the room it took the last message available in the room rather then showing error so i opted for the way i committed which finds the message based on the user name

here is the proof of my raised statement
Screenshot from 2025-02-24 07-11-57

here you can see both works exactly fine when comes to get other users message but in the case where there is no other user message the above command gets the last message in the room

@VipinDevelops
Copy link
Collaborator

this should be top of mine PR right ?

@not-meet
Copy link
Contributor Author

hi @VipinDevelops i tried what you wanted (to make a pr on top of yours showing in the main repo of quick replies)
but since your branch is made in your fork only , GitHub don't allow me to set it as the base branch for my PR in the main repo.

I think for me to create a pr on top of yours which shows in the main repo of quick replies , it should be available on the main repo i believe

what i did from my side

  • i have made this pr which has exact code of yours pr branch with my changes
  • i also have added a pr on your forked repo

if possible kindly suggest me a way if you know any way to do so that will be a great help !

@VipinDevelops
Copy link
Collaborator

@not-meet This should not be done this way just making things complex.

@VipinDevelops
Copy link
Collaborator

@not-meet Leave the PR I'll see it myself

@moyrsd
Copy link

moyrsd commented Apr 10, 2025

@VipinDevelops Can I work on this, I have explained what I want to do in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants