Skip to content

Conversation

not-meet
Copy link
Contributor

@not-meet not-meet commented Feb 26, 2025

Issue(#40)

Closes #40

Acceptance Criteria fulfillment

  • AI modal should take the last message of the other user
  • User receives a error notification when no valid messages are found to generate AI response

What changes i made ?

  • I changed the logic from poping the last message to finding the last message form a distinct user
  • I also added a notification in all the languages to notify the user if there are no user message in the room

POC -

Screencast.from.2025-02-27.04-42-14.webm

i have tested out the logic and also checked the error message in all the languages available

@not-meet not-meet changed the title [fix] : Filtered out self messages from AI reply generation [FIX] : Filtered out self messages from AI reply generation Feb 26, 2025
@VipinDevelops
Copy link
Collaborator

can you improve the string language and can we do both of this type of handling in a single PR?

@VipinDevelops
Copy link
Collaborator

@not-meet I'll take care of this in my PR no need for this one also its just duplicated code in this PR nothing new here, You might try doing something better once my pr is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] : AI reply modal don't have last users message

2 participants