Skip to content

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Feb 2, 2025

Brief Title

Acceptance Criteria fulfillment

  • allow users to paste images.

Fixes #947

Video/Screenshots

Screencast.from.2025-02-02.11-32-43.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-948 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory Spiral-Memory added the chore a subtle fix label Feb 2, 2025
@Spiral-Memory Spiral-Memory changed the title Allow users to paste images from clipboard chore: Allow users to paste images from clipboard Feb 2, 2025
@Spiral-Memory
Copy link
Collaborator

Hi @thepiyush-303
Why only images, can we make it generic ?

@thepiyush-303
Copy link
Contributor Author

Hey @Spiral-Memory
you mean pasting files also?

@Spiral-Memory
Copy link
Collaborator

Yeah, anything

Image,
Files
Videos

@Spiral-Memory Spiral-Memory changed the title chore: Allow users to paste images from clipboard Allow users to paste images from clipboard Feb 2, 2025
@thepiyush-303
Copy link
Contributor Author

I think every browser do not support copying files, videos,
for e.g i am using firefox and it does not support copying files.

@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Feb 2, 2025

Okay, so only images will be possible 🤔

Cool, then, Can you optimize this code, looks there there are many manual checks, can we do better ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a subtle fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to Paste Images from Clipboard

2 participants