Skip to content

feat: Added KaTeX icon/button to chat toolbar for documentation access #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+62 −4
Open

feat: Added KaTeX icon/button to chat toolbar for documentation access #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions packages/react/src/views/ChatInput/ChatInputFormattingToolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ const ChatInputFormattingToolbar = ({
inputRef,
triggerButton,
optionConfig = {
surfaceItems: ['emoji', 'formatter', 'link', 'audio', 'video', 'file'],
surfaceItems: ['emoji', 'formatter', 'link', 'katex', 'audio', 'video', 'file'],
formatters: ['bold', 'italic', 'strike', 'code', 'multiline'],
smallScreenSurfaceItems: ['emoji', 'video', 'audio', 'file'],
smallScreenSurfaceItems: ['emoji', 'video', 'audio', 'file', 'katex'],
popOverItems: ['formatter', 'link'],
},
}) => {
Expand Down Expand Up @@ -56,6 +56,9 @@ const ChatInputFormattingToolbar = ({
};
const handleFormatterClick = (item) => {
formatSelection(messageRef, item.pattern);
if (item.onClick) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this ?

item.onClick();
}
setPopoverOpen(false);
};
const handleEmojiClick = (emojiEvent) => {
Expand Down Expand Up @@ -190,6 +193,33 @@ const ChatInputFormattingToolbar = ({
</ActionButton>
</Tooltip>
),
katex: (
<Tooltip text="KaTeX" position="top" key="katex">
<ActionButton
ghost
style={{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not pass these many styles directly, instead utilise css jsx files for that

padding: '0 8px',
minWidth: 'auto',
fontSize: '17px',
fontFamily: 'KaTeX_Math-Italic, Times New Roman',
color: theme.palette?.mode === 'dark' ? '#fff' : '#2f343d',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
transform: 'scaleX(0.9) rotate(-2deg)',
position: 'relative',
top: '-1px'
}}
disabled={isRecordingMessage}
onClick={() => {
if (isRecordingMessage) return;
window.open('https://katex.org/docs/supported.html', '_blank');
}}
>
𝒇
</ActionButton>
</Tooltip>
),
formatter: formatters
.map((name) => formatter.find((item) => item.name === name))
.map((item) =>
Expand All @@ -214,7 +244,7 @@ const ChatInputFormattingToolbar = ({
</>
) : (
<Tooltip
text={item.name}
text={item.tooltip}
position="top"
key={`formatter-${item.name}`}
>
Expand All @@ -225,6 +255,9 @@ const ChatInputFormattingToolbar = ({
onClick={() => {
if (isRecordingMessage) return;
formatSelection(messageRef, item.pattern);
if (item.onClick) {
item.onClick();
}
}}
>
<Icon
Expand Down Expand Up @@ -294,7 +327,7 @@ const ChatInputFormattingToolbar = ({
if (itemInFormatter) {
return (
<Tooltip
text={itemInFormatter.name}
text={itemInFormatter.tooltip}
position="top"
key={`formatter-${itemInFormatter.name}`}
>
Expand Down
23 changes: 23 additions & 0 deletions packages/ui-elements/src/components/Icon/icons/KaTeX.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React from 'react';

const KaTeX = (props) => (
<svg
width="21"
height="21"
viewBox="0 0 21 21"
fill="none"
xmlns="http://www.w3.org/2000/svg"
{...props}
>
<path
d="M4 4L8 10.5L4 17H6L9.25 11.5L6 6H4Z"
fill="currentColor"
/>
<path
d="M17 4H10V6H12.5V15H10V17H17V15H14.5V6H17V4Z"
fill="currentColor"
/>
</svg>
);

export default KaTeX;
2 changes: 2 additions & 0 deletions packages/ui-elements/src/components/Icon/icons/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import Download from './Download';
import ChevronDown from './ChevronDown';
import ChevronLeft from './ChevronLeft';
import Key from './Key';
import KaTeX from './KaTeX';
import Attachment from './Attachment';
import CircleArrowDown from './CircleArrowDown';
import Online from './Online';
Expand Down Expand Up @@ -116,6 +117,7 @@ const icons = {
'chevron-down': ChevronDown,
'chevron-left': ChevronLeft,
key: Key,
katex: KaTeX,
attachment: Attachment,
'circle-arrow-down': CircleArrowDown,
online: Online,
Expand Down
Loading