Skip to content

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jul 10, 2025

Proposed changes

Create inline errors in ProfileView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-256

How to test or reproduce

  • Open the app;
  • Go to ProfileView;
  • Try to edit your profile;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 22, 2025 21:22 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak temporarily deployed to experimental_android_build July 22, 2025 21:22 — with GitHub Actions Inactive
@OtavioStasiak OtavioStasiak temporarily deployed to experimental_ios_build July 22, 2025 21:22 — with GitHub Actions Inactive
@OtavioStasiak OtavioStasiak had a problem deploying to upload_experimental_android July 22, 2025 21:48 — with GitHub Actions Failure
Copy link

Android Build Available

Rocket.Chat Experimental 4.63.0.87790

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRIs9fwwnEJ6CBDFAPG0aLxVfRmy5HEQnO-4arBlfQhXFvKRQAiyfWmKxrJQYwP6E9Bg7B0_2V9BtXKHNFl

@Rohit3523
Copy link
Collaborator

Rohit3523 commented Jul 22, 2025

I noticed one issue but not sure if this PR introduce that

If we change email to an existing one it shows the error modal but text input keeps the new email instead of reverting to old one even if I change the screen too

Steps:-

  1. Try to change email with existing one
  2. Click on save and dismiss the modal
  3. observe the email field, it keep the new one
  4. Change screen
  5. Go to profile again
  6. Observe email text input, it shows the new one

It only revert to old if we restart the app.

Copy link

iOS Build Available

Rocket.Chat Experimental 4.63.0.87790

@OtavioStasiak
Copy link
Contributor Author

It's happening in development as well. I'll fix it in this PR. Thanks @Rohit3523 🙏🏻

I noticed one issue but not sure if this PR introduce that

If we change email to an existing one it shows the error modal but text input keeps the new email instead of reverting to old one even if I change the screen too

Steps:-

  1. Try to change email with existing one
  2. Click on save and dismiss the modal
  3. observe the email field, it keep the new one
  4. Change screen
  5. Go to profile again
  6. Observe email text input, it shows the new one

It only revert to old if we restart the app.

@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 22, 2025 22:27 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 22, 2025 22:27 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 22, 2025 22:27 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 24, 2025 21:41 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 24, 2025 21:41 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 24, 2025 21:41 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak marked this pull request as ready for review July 29, 2025 20:27
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 29, 2025 20:30 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 30, 2025 22:18 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 30, 2025 22:18 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 30, 2025 22:18 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak merged commit 2ad4055 into develop Jul 31, 2025
10 of 18 checks passed
@OtavioStasiak OtavioStasiak deleted the feat-a11y-inline-errors-profileview branch July 31, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants