Skip to content

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Aug 27, 2025

Proposed changes

Push notification wasn't working properly on Android after #6478 was merged.
Applied this comment from react-native-notifications repo and now push is working fine.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-992

How to test or reproduce

  • Receive normal push
  • Reply push
  • Secured push notification (receive a push on mobile.rocket.chat)
  • Video call
  • E2EE push notifications are going to be implemented on a separate PR

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello force-pushed the fix.push-notification-android branch from 71b98fb to aa926be Compare August 27, 2025 18:44
@diegolmello diegolmello had a problem deploying to official_android_build August 27, 2025 19:06 — with GitHub Actions Error
@diegolmello diegolmello temporarily deployed to experimental_android_build August 27, 2025 19:06 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_ios_build August 27, 2025 19:06 — with GitHub Actions Inactive
@diegolmello diegolmello had a problem deploying to upload_experimental_android August 27, 2025 20:11 — with GitHub Actions Error
Copy link

Android Build Available

Rocket.Chat Experimental 4.64.0.107162

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNT5nqNBX8LP-xGAI6Veb1aTiY5djb-KlnhqjIayZT6XPIiUmZOf0Sc5DbU-K55vnRMqi4oZKDyfaQ1MBZ-g

Copy link

iOS Build Available

Rocket.Chat Experimental 4.64.0.107163

@diegolmello diegolmello had a problem deploying to official_android_build August 28, 2025 17:33 — with GitHub Actions Error
@diegolmello diegolmello temporarily deployed to experimental_android_build August 28, 2025 17:33 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_ios_build August 28, 2025 17:33 — with GitHub Actions Inactive
@diegolmello diegolmello had a problem deploying to upload_experimental_android August 28, 2025 18:29 — with GitHub Actions Error
Copy link

Android Build Available

Rocket.Chat Experimental 4.64.0.107164

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRlpqyhWj3Uojkpbh1BbJwae5_p_IKCwzK4GJk_niXSSOepAtyiBUZ_aNng8uOFFpFKyX6lVgQETklLwCss

Copy link

iOS Build Available

Rocket.Chat Experimental 4.64.0.107165

@diegolmello diegolmello marked this pull request as ready for review September 3, 2025 14:00
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello force-pushed the fix.push-notification-android branch from e11236c to fc4add6 Compare September 3, 2025 17:23
@diegolmello diegolmello merged commit 5a93471 into develop Sep 3, 2025
4 of 7 checks passed
@diegolmello diegolmello deleted the fix.push-notification-android branch September 3, 2025 17:24
@diegolmello diegolmello had a problem deploying to experimental_android_build September 3, 2025 17:28 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to official_android_build September 3, 2025 17:28 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants