Skip to content

chore: add E2E tests for sidebar filters #36394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: feat/sidebar-filters
Choose a base branch
from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jul 10, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-102

SIDE2-116

Copy link
Contributor

dionisio-bot bot commented Jul 10, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: c686ca0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36394/

Built to branch gh-pages at 2025-07-23 02:02 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.62%. Comparing base (1e0ca07) to head (c686ca0).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36394      +/-   ##
========================================================
- Coverage                 64.92%   64.62%   -0.30%     
========================================================
  Files                      3178     3157      -21     
  Lines                    105872   105268     -604     
  Branches                  20040    19938     -102     
========================================================
- Hits                      68734    68028     -706     
- Misses                    34553    34704     +151     
+ Partials                   2585     2536      -49     
Flag Coverage Δ
e2e 54.45% <0.00%> (-1.41%) ⬇️
unit 70.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal marked this pull request as ready for review July 15, 2025 23:49
@yash-rajpal yash-rajpal requested a review from a team as a code owner July 15, 2025 23:49
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 72dc5c0 to 1e0ca07 Compare July 22, 2025 22:19
@dougfabris dougfabris requested review from a team as code owners July 22, 2025 22:19
@dougfabris dougfabris force-pushed the chore/sidebar-filter-tests branch from 0f6195a to c686ca0 Compare July 23, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants