Skip to content

Conversation

tacerus
Copy link

@tacerus tacerus commented Sep 5, 2024

The "#list" command should not be treated as a failure when it is both a legitimate request by the client, and correctly answered by the server. It is commonly used for assessing whether a rsync endpoint is healthy, having it return with a non-zero exit code causes misleading error reports, and, in case of socket activation, failed service instances on the server.

@tridge
Copy link
Member

tridge commented Sep 26, 2024

what testing has been done? Have you tested both inetd operation and running as a daemon?

@tacerus
Copy link
Author

tacerus commented Sep 26, 2024

I tested running through a socket activated systemd service.

The "#list" command should not be treated as a failure when it is
both a legitimate request by the client, and correctly answered by the
server. It is commonly used for assessing whether a rsync endpoint is
healthy, having it return with a non-zero exit code causes misleading
error reports, and, in case of socket activation, failed service
instances on the server.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants