Skip to content

Add detailed error information for filtered_fwrite failures #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UMAHunter
Copy link

I frequently see the following error in our local

2025/04/24 01:13:29 [905477] send_files(632399, /var/ms/01/002/002/tbms1s_613F1EA121BB53)
2025/04/24 01:13:29 [905477] file has vanished: "/var/ms/01/002/002/tbms1s_613F1EA121BB53"
2025/04/24 01:13:29 [905477] rsync error: errors with program diagnostics (code 13) at log.c(245) [receiver=3.1.3]
2025/04/24 01:13:29 [905477] [receiver] _exit_cleanup(code=13, file=log.c, line=245): about to call exit(13)

line 244 and 245 in log.c is:

if (ob != outbuf && fwrite(outbuf, ob - outbuf, 1, f) != 1)
	exit_cleanup(RERR_MESSAGEIO);

It invokes logging message, but not detailed enough to diagnose how fwrite() fails. This patch should output the errno to stderr or stdout(avoid the 'f' in the previous line) to see what fwrite() happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant