Adjust formatting rules to use i18n translations for :format

[DRBragg]

What's changing?
Allow the default format for a language be configured via I18n.

Why?
Fixes #233 (which was closed with no solution).

This is an updated version of #1115

[yukideluxe]

I like! Thanks @DRBragg 👏🏻

PS. default_format is calling currency.format which is the same as what the Money::LocaleBackend::Currency#format does. I see a bit of room for cleanup here but I have a semi-ready branch to remove the use_i18n deprecation and I can tackle that! 🙏🏻

[DRBragg]

Awesome! Thanks @yukideluxe. Just for planning purposes is there an ETA on version 7? This PR was born from some work I'm doing in Podia's codebase and I'm just wondering if I need to implement something similar for us or if we can try to wait for the upgrade. Thanks!

[yukideluxe]

Awesome! Thanks @yukideluxe. Just for planning purposes is there an ETA on version 7? This PR was born from some work I'm doing in Podia's codebase and I'm just wondering if I need to implement something similar for us or if we can try to wait for the upgrade. Thanks!

I am slowly trying to remove the last very old deprecation – use_i18n – and writing a short migration guide, then we will be ready to bump the major version, but I can't commit to a date because we have a lot of things going on right now 🙈

That said, at Harvest we've been pulling money changes directly from GitHub for a while now, and that worked very well for us! Is it something you could do at Podia!? 😳

[DRBragg]

Awesome! Thanks @yukideluxe. Just for planning purposes is there an ETA on version 7? This PR was born from some work I'm doing in Podia's codebase and I'm just wondering if I need to implement something similar for us or if we can try to wait for the upgrade. Thanks!

I am slowly trying to remove the last very old deprecation – use_i18n – and writing a short migration guide, then we will be ready to bump the major version, but I can't commit to a date because we have a lot of things going on right now 🙈

That said, at Harvest we've been pulling money changes directly from GitHub for a while now, and that worked very well for us! Is it something you could do at Podia!? 😳

Yea, we'd be down for that. I'll take a look at the changelog but if you have (even a rough draft of) the migration guide I'd like to look at that too. I don't think it will take much to migrate but I wouldn't mind the look.

[yukideluxe]

Awesome! Thanks @yukideluxe. Just for planning purposes is there an ETA on version 7? This PR was born from some work I'm doing in Podia's codebase and I'm just wondering if I need to implement something similar for us or if we can try to wait for the upgrade. Thanks!

I am slowly trying to remove the last very old deprecation – use_i18n – and writing a short migration guide, then we will be ready to bump the major version, but I can't commit to a date because we have a lot of things going on right now 🙈
That said, at Harvest we've been pulling money changes directly from GitHub for a while now, and that worked very well for us! Is it something you could do at Podia!? 😳

Yea, we'd be down for that. I'll take a look at the changelog but if you have (even a rough draft of) the migration guide I'd like to look at that too. I don't think it will take much to migrate but I wouldn't mind the look.

@DRBragg I don't have anything written yet but it won't differ much from the current CHANGELOG! https://github.com/RubyMoney/money/blob/main/CHANGELOG.md#upcoming-700alpha. I think a great job has been done to keep that updated and very detailed! Props to @sunny!

[DRBragg]

@yukideluxe Podia is now running money from main in prod! 🎉 We'll let you know if we run into anything but so far the upgrade was smooth 👍

[yukideluxe]

@DRBragg thanks for letting me know! That brings some peace of mind and makes me a bit less stressed about the major bump 😇