Skip to content

Conversation

@sunny
Copy link
Member

@sunny sunny commented Nov 4, 2025

Introduces a basic .rubocop.yml and a .rubocop-todo.yml and applying some easy autocorrectable rules.

@sunny sunny mentioned this pull request Nov 14, 2025
tagliala

This comment was marked as resolved.

@tagliala
Copy link
Contributor

tagliala commented Nov 15, 2025

Hello,

Yesterday, I had some reservations about the number of changes in a single PR, but I did not mention it. Unfortunately, today I saw the exact issue I was concerned about occur in another repository, so I want to share my thoughts.

If a large PR like this is merged with squash, it can introduce subtle issues that are difficult to track down such as what happened here: activeadmin/activeadmin#8851.

A large commit related to RuboCop rules in i18n-tasks (glebm/i18n-tasks@144c09d) inadvertently broke or changed something. Because most changes seemed safe, it is now very hard to pinpoint exactly what went wrong.

To help prevent hidden issues and facilitate future debugging, I kindly suggest the following:

  • Avoid merging this PRs with squash commits.
  • Split work into smaller, well-scoped stages or PRs, especially for mechanical or stylistic changes.
    This approach makes it easier to review, spot errors early, and trace the cause of any future issues.

Thank you for considering this!


edit: rubocop was not the issue in that case, but the concern remains valid

@sunny
Copy link
Member Author

sunny commented Nov 17, 2025

You are absolutely right! I’ll see what I can do to split this (either through a merge commit and good looking different commits or through several PRs). <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants