Clean up PR #278 review findings#279
Merged
blondfrogs merged 3 commits intoRunOnFlux:remove_boost_c++_20_rebasedfrom Apr 27, 2026
Merged
Conversation
…ead import, Windows typedef - boost.mk: Remove compiled library build (bootstrap/b2), just copy headers - net.cpp: Remove duplicate includes (4x condition_variable, 2x mutex) from bad rebase - fluxd.cpp: Remove stray vector/thread includes from copyright block - mempool_limit.h: Remove dead boost/optional.hpp include (code uses std::optional) - fs.cpp: Use OVERLAPPED typedef instead of _OVERLAPPED struct tag Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PAIRTYPE(t1, t2) was a pre-C++11 convenience macro for std::pair. Replace all 34 usages with structured bindings and remove the macro definition from utilstrencodings.h. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9 tasks
blondfrogs
merged commit bbce649
into
RunOnFlux:remove_boost_c++_20_rebased
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cp -r boost). Onlysignals2andmulti_indexare used — both header-only. Boost depends step goes from several minutes (bootstrap + b2 compile) to seconds (header copy).condition_variable, 2xmutex, strayvector/thread/chrono) from bad rebasevector/threadincludes interleaved in copyright blockboost/optional.hppinclude (code usesstd::optional)OVERLAPPEDtypedef instead of_OVERLAPPEDstruct tag (Windows)PAIRTYPE(t1, t2)macro fromutilstrencodings.hand replaced all 34 usages across 10 files with C++20 structured bindings (e.g.for (auto& [txid, wtx] : mapWallet))Test plan
zcutil/build.sh -j16) — all 4 binaries produced, zero errorsldd🤖 Generated with Claude Code