Skip to content

Conversation

@bansikah22
Copy link
Collaborator

🛠️ PR Summary

✅ What’s Updated

This PR introduces and improves the local CI pipeline for Rust development by ensuring all required tools are properly installed before execution. Key updates include:

  • Ensured cargo-audit is installed before running the security audit step to avoid errors like:
error: binary `cargo-audit` already exists in destination
Add --force to overwrite
  • Added check and install for cargo-nextest to prevent the following error during test execution:

    error: no such command: `nextest`
    
  • Enhanced the local CI script (ci-local.sh) to make it fully self-contained and robust, handling missing dependencies gracefully.

This makes the local development experience consistent with the CI environment and helps catch issues early.

@bansikah22
Copy link
Collaborator Author

@Christiantyemele you can check now

@Christiantyemele Christiantyemele self-requested a review April 8, 2025 12:46
@bansikah22 bansikah22 requested review from Dericko681, chojuninengu, micheal-ndoh and onelrian and removed request for Dericko681 and micheal-ndoh April 8, 2025 12:57
Comment on lines +59 to 62
run: cargo install cargo-audit --force

- name: Run Security Audit
run: cargo audit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bansikah22 👋🏽

Instead of:

run: cargo install cargo-audit --force

We could use:

- uses: taiki-e/install-action@v2
  with:
    tool: cargo-audit
- run: cargo audit

It’s faster, avoids compiling from source, and prevents reinstall issues that usually require --force. It’s also designed for CI use and handles caching automatically. Let me know what you think!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onelrian great idea i will update that Thank you

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we're here for
you're welcome

@bansikah22
Copy link
Collaborator Author

@Christiantyemele @onelrian @ndefokou i will be creating a new branch with a new pr because of the changes above requested by onelrian so i will request for your review so that you guys can approve again please

@bansikah22
Copy link
Collaborator Author

This pr has been closed to use another one with same commits and work on the branch ci/refactor-ci-v2

@bansikah22 bansikah22 closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants