Skip to content

Undef zombie and some other code cleanups #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2025
Merged

Undef zombie and some other code cleanups #221

merged 3 commits into from
Mar 22, 2025

Conversation

@Firestar99
Copy link
Member

best reviewed commit by commit

I see this quite commonly:

let undef = self.undef(ret_ty);
self.zombie(undef.def(self), "memcmp not implemented");
undef

And I replaced it with this:

self.undef_zombie(ret_ty, "memcmp not implemented")

Among other smaller cleanups

@LegNeato LegNeato added this pull request to the merge queue Mar 22, 2025
Merged via the queue into Rust-GPU:main with commit 05042d1 Mar 22, 2025
7 checks passed
@Firestar99 Firestar99 deleted the undef_zombie branch March 30, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LegNeato LegNeato LegNeato approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Firestar99 @LegNeato