add SpirvBuilder::target_dir_path to set the target dir explicitly
#223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dir explicitly
LegNeato
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have two shader crates, one has to wait for the other to finish compiling before it can compile. That's a good thing, as you don't have to recompile any dependencies twice.
But if you have two shader crates with differing capabilities or features, they are forced to do a clean rebuild every time, adding 30s each build, even if nothing changed. Explicitly specifying a target dir enables me to specify a separate build dir for each shader crate and work around this issue.
I do think a better policy wrt. capabilities and features will be needed in the future, but this will do for now.