Skip to content

Add HitTriangleVertexPositionsKHR built-in for ray tracing pipelines #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

jcmnn
Copy link
Contributor

@jcmnn jcmnn commented Jul 17, 2025

@Firestar99 Firestar99 changed the title Add HitTriangleVertexPositionsKHR symbol for ray tracing pipelines Add HitTriangleVertexPositionsKHR built-in for ray tracing pipelines Jul 19, 2025
@LegNeato
Copy link
Collaborator

Thanks for the PR! I don't know enough about this area to review, looks sensible but not sure if other things need to be added. Are you actively testing this?

Copy link
Member

@Firestar99 Firestar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just squashed your commits (since we don't squash and merge queue doesn't allow you to switch to squashing for individual PRs)

Since the built-in must be of type Vec3, I would have loved to see some kind of validation on that, but we don't have a good system yet to do these sort of validations. So let's merge it for now and whenever we get such a system, we can still add that this must be a Vec3.

I may make a followup to also add that capability to ray query.

@Firestar99
Copy link
Member

Sorry for the constant canceling of CI, see #342

@Firestar99 Firestar99 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into Rust-GPU:main with commit f57ffd5 Jul 21, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants