Skip to content

spirv_asm: use line_spans for slightly better source locations. #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

spirv_asm: use line_spans for slightly better source locations. #369

merged 1 commit into from
Aug 18, 2025

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 18, 2025

Noticed that this should be possible while preparing:

While we can do better than this, I feel like the test diffs speak for themselves.

@eddyb eddyb mentioned this pull request Aug 18, 2025
Draft
@eddyb eddyb enabled auto-merge August 18, 2025 18:12
LegNeato
LegNeato approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sweet! Much better.

@eddyb eddyb added this pull request to the merge queue Aug 18, 2025
Merged via the queue into Rust-GPU:main with commit e0dfdd1 Aug 18, 2025
13 checks passed
@eddyb eddyb deleted the inline-asm-spans branch August 18, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

@Firestar99 Firestar99 Awaiting requested review from Firestar99 Firestar99 is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyb @LegNeato