Add BasePlateBottomSideRound feature, fix misc issues#166
Open
ranta wants to merge 16 commits intoRuudjhuu:mainfrom
Open
Add BasePlateBottomSideRound feature, fix misc issues#166ranta wants to merge 16 commits intoRuudjhuu:mainfrom
ranta wants to merge 16 commits intoRuudjhuu:mainfrom
Conversation
No changes to code
This fixes the top inside corners of the baseplate having a corner, which doesn't look rounded
This is useful e.g. when BasePlateBlockFull is not wanted, but extra height is needed for increased BasePlateBottomSideRound radius
ranta
force-pushed
the
baseplate-side-round
branch
from
239236a to
746df9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes
BasePlateBottomSideRoundfeatureextra_heightinBasePlateBlockFrame.mypydev dependency and cleaned typing/lint issues.BasePlateBottomSideRound in use
Non-manifold edges