fix: search across all loaded articles#1361
Open
jyoti-5906 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you @, for creating the PR and contributing to our UltimateHealth project 💗. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a search issue in
HomeScreenwherehandleSearchwas filtering onlyarticleData.articles, which contains the most recently fetched page of articles.Since the application accumulates paginated articles in
allArticlesRef.current, articles from previously loaded pages could be omitted from search results. The search logic has been updated to useallArticlesRef.currentso that users can search across all loaded articles.Changes Made
handleSearchto search againstallArticlesRef.currentType of Change
Select your work-area
Related Issue
Fixes: #1358
Add your Work Example
Before:
After:
Fixes (mention the issue number which this fixes)
Closes #1358
Checklist
Undertaking