Skip to content

fix: remove console.log calls from notification preferences screen - #2383

Merged
SB2318 merged 1 commit into
SB2318:mainfrom
namann5:fix/2379-notification-preferences-logging
Aug 13, 2026
Merged

fix: remove console.log calls from notification preferences screen#2383
SB2318 merged 1 commit into
SB2318:mainfrom
namann5:fix/2379-notification-preferences-logging

Conversation

@namann5

@namann5 namann5 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses #2379

Problem

NotificationPreferencesScreen.tsx logs raw data to the console unconditionally:

  • console.log("Preference data", preferencesData) on every render
  • console.log('Fetched Preferences Data:', preferencesData) on every fetch
  • console.log("Clusters", clusters) inside the pre-fill effect
  • console.log('Preferences saved successfully:', selectedIds) after each save

This leaks preference payloads into production console output on every render/save and adds noise to dev logs.

Fix

Removed all four console.log calls. No behavioural change ΓÇö the pre-fill and invalidateQueries logic is untouched.

Testing

  • yarn lint ΓÇö 0 errors.
  • No console.log statements remain in the file.

… screen

The fetch, pre-fill, and save handlers dumped raw payloads and saved
IDs to the console on every render and save, leaking preference data
in production builds. Removed all four console.log calls.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you @, for creating the PR and contributing to our UltimateHealth project 💗.
Our team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@github-actions

Copy link
Copy Markdown
Contributor

Automated Review Feedback

No major issues were identified during this review.

The implementation appears consistent with the repository standards and the modified files were reviewed successfully.

Maintainer Note:

Maintainer @SB2318 will review this pull request after the initial automated review cycle is complete.

@SB2318
SB2318 merged commit 1e1803a into SB2318:main Aug 13, 2026
21 of 22 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants