Skip to content

Conversation

@henrylay97
Copy link
Member

@nathanielerowe pointed out some CI tests were showing variation in the opt0 variables in the CAFs CRUMBS object.

Theory that this results from the lack of initialisation of these variables (seems highly likely). Looks like I never added the initialisation when CRUMBS was updated to use OpT0 as well as SimpleFlash. This PR fixes that.

@henrylay97 henrylay97 requested a review from nathanielerowe May 6, 2025 15:38
@henrylay97 henrylay97 self-assigned this May 6, 2025
@henrylay97 henrylay97 added the bug Something isn't working label May 6, 2025
@kjplows kjplows moved this to Urgent checks in SBN software development May 6, 2025
Copy link
Contributor

@nathanielerowe nathanielerowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@kjplows
Copy link
Contributor

kjplows commented May 7, 2025

trigger build

@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 7, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development May 7, 2025
@kjplows kjplows merged commit 7f028ad into develop May 8, 2025
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development May 8, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development May 8, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Jul 10, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_06_00_01 milestone Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

5 participants