Skip to content

Conversation

@npallat
Copy link
Contributor

@npallat npallat commented Sep 23, 2025

Description

This includes new trigger CAF variables to trigger StandardRecord, specifically a bool of passed/failed trigger, number of PMT pairs over threshold, and two variables for the purpose of validation giving us the trigger response in a flattened vector and the size of the pulses (so the vector can be un-flattened).

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer ([PetrilloAtWork])
  • Does this affect the standard workflow? [No]
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch! [These changes are for the validation production, not the ongoing production/v10_06_00 ]

Relevant PR links (optional)

Yes, this needs to be merged after the changes to detsim (where these data products are created and added to the event) and with updates to sbncode and sbnobj.

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
Here are a couple relevant links to presentations on this work:

@kjplows kjplows moved this to Partially reviewed in SBN software development Sep 24, 2025
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear from the description what the two levels in the vector<vector<int>> represent.
It would be good to explain that in the documentation.

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new variables need to be initialized in the constructor, which seems not to be happening (the .cxx file is not included in the PR). The std::vector objects are constructed empty by default, so they don't need explicit initialisation if "empty" is a good default. The passed_trigger should likely be initialised to false, and num_pairs_over_threshold to caf::kUninitializedInt (need to #include "sbnanaobj/StandardRecord/SRConstants.h").

Incidentally, this kind of oversights is the reason why I recommend initialisation in the definition of the class rather than in the constructor — but that hasn't been the custom in CAF. 🤷

@nathanielerowe nathanielerowe removed the request for review from PetrilloAtWork October 1, 2025 16:03
@kjplows kjplows requested a review from rtriozzi October 2, 2025 13:21
@kjplows
Copy link
Contributor

kjplows commented Oct 2, 2025

Technically dismissing the review from @PetrilloAtWork after offline follow up that confirms changes satisfy the review (can't log in to GIthub at the moment to hit "Approve")

@kjplows kjplows dismissed PetrilloAtWork’s stale review October 2, 2025 15:29

Offline followup from @PetrilloAtWork confirms changes are good but can't login to Github to approve changes. Dismissing review to clear the "requested changes" flag

@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Oct 2, 2025
@kjplows
Copy link
Contributor

kjplows commented Oct 2, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Oct 2, 2025
@kjplows kjplows merged commit 982de3d into develop Oct 2, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Oct 2, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Oct 2, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Oct 20, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_10_05 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request trigger

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

9 participants