Skip to content

Reopened: PMT Software Trigger class #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjplows merged 9 commits into from
Nov 21, 2025
Merged

Reopened: PMT Software Trigger class #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79083a3
no-op to reopen PR with
kjplows Nov 21, 2025
235e969
Restore ClassDef=15 to what v10_00_13 originally had
kjplows Nov 21, 2025
fa27625
merge develop into feature/lynnt_Fall25_pmtmetrics
kjplows Nov 21, 2025
47cffd7
first commit of software trigger additions
lynnt20 Nov 12, 2025
18be1b0
update classes_def with new software trigger class, editing ClassesDe…
lynnt20 Nov 13, 2025
e686dd1
inherit SRConstants instead
lynnt20 Nov 18, 2025
185d58f
Update classes_def.xml
kjplows Nov 21, 2025
07de331
Merge branch 'develop' into feature/lynnt_Fall25_pmtmetrics
kjplows Nov 21, 2025
b104267
add descriptions to the Software Trigger class
lynnt20 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions sbnanaobj/StandardRecord/SRSoftwareTrigger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**
* @file /sbnanaobj/StandardRecord/SRSoftwareTrigger.h
* @brief Defines CAF data structures to store sbnd::trigger::pmtSoftwareTrigger objects (header).
* @author Lynn Tung
* @date November 12, 2025
*
*/

#ifndef SRSOFTWARETRIGGER_H
#define SRSOFTWARETRIGGER_H

#include "sbnanaobj/StandardRecord/SRConstants.h"

namespace caf{

/**
* @brief A struct to store software trigger information for SBND Data and MC
*/

struct SRSoftwareTrigger {
int npmts = caf::kUninitializedInt; ///< In data, number of pmts over threshold; In simulation, number of pmt waveforms used for the trigger sim
float flash_peaktime = caf::kSignalingNaN; ///< Peak time of the flash [us]
float flash_peakpe = caf::kSignalingNaN; ///< Peak amplitude of the flash, 1 PE = 12.5 ADC
};
}

#endif
3 changes: 2 additions & 1 deletion sbnanaobj/StandardRecord/StandardRecord.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "sbnanaobj/StandardRecord/SRFakeReco.h"
#include "sbnanaobj/StandardRecord/SROpFlash.h"
#include "sbnanaobj/StandardRecord/SRTrigger.h"
#include "sbnanaobj/StandardRecord/SRSoftwareTrigger.h"
#include "sbnanaobj/StandardRecord/SRInteractionDLP.h"
#include "sbnanaobj/StandardRecord/SRInteractionTruthDLP.h"

Expand Down Expand Up @@ -66,7 +67,7 @@ namespace caf
bool pass_flashtrig = false; ///< Whether this Record passed the Flash Trigger requirement
SRSBNDFrameShiftInfo sbnd_frames; ///< List of Frame Shift in event in unit [ns] (SBND)
SRSBNDTimingInfo sbnd_timings; ///< List of Timing Info in event in UNIX timestamp format(SBND)

SRSoftwareTrigger soft_trig; ///< Software Trigger Info in event
int ndlp = 0; ///< Number of reco DLP (ML) interactions.
std::vector<SRInteractionDLP> dlp; ///< Reco DLP (ML) interactions.
int ndlp_true = 0; ///< Number of true DLP (ML) interactions.
Expand Down
7 changes: 6 additions & 1 deletion sbnanaobj/StandardRecord/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<!-- art::Wrappers for these products are defined in CAFMaker -->

<lcgdict>
<class name="caf::StandardRecord" ClassVersion="15">
<class name="caf::StandardRecord" ClassVersion="16">
<version ClassVersion="16" checksum="3621177915"/>
<version ClassVersion="15" checksum="1805006132"/>
<version ClassVersion="14" checksum="1860171062"/>
<version ClassVersion="13" checksum="1979816256"/>
Expand Down Expand Up @@ -445,6 +446,10 @@
<version ClassVersion="10" checksum="4144120809"/>
</class>

<class name="caf::SRSoftwareTrigger" ClassVersion="10">
<version ClassVersion="10" checksum="2302036479"/>
</class>

<enum name="caf::Det_t" ClassVersion="10"/>
<enum name="caf::Plane_t" ClassVersion="10"/>
<enum name="caf::Wall_t" ClassVersion="10"/>
Expand Down