Skip to content

Conversation

@kjplows
Copy link
Contributor

@kjplows kjplows commented Apr 10, 2025

Description

This is a companion PR to sbnobj/#128, which is itself a companion PR to sbnanaobj/#110 opened by @jedori0228 .
This depends on sbnobj/#128, and should be merged in at the same time as the above two PRs.

The reason why these companion PRs are opened is because of a stipulated need to synchronise sbnanaobj/StandardRecord/SREnums.h::enum ReweightType_t with the member fRWType of class EventWeightParameterSet (see sbnobj/Common/SBNEventWeight/EventWeightParameterSet.h), which duplicates that enum.

This PR follows through on the synchronisation between sbnanaobj -> ReweightType_t --> sbnobj -> fRWType, as there were differences in capitalisation that had been introduced into sbnanaobj but not sbnobj.

Calling @jedori0228 (who authored the original sbnanaobj PR) and @PetrilloAtWork (who reviewed it) for review.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows
Copy link
Contributor Author

kjplows commented Apr 10, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbnobj#128

@kjplows kjplows moved this to Open pull requests in SBN software development Apr 10, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

Copy link
Contributor

@jedori0228 jedori0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjplows , this is a good PR to have!

@kjplows
Copy link
Contributor Author

kjplows commented Apr 10, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbnobj#128

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@kjplows
Copy link
Contributor Author

kjplows commented Aug 9, 2025

trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnobj#128

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Aug 9, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Aug 11, 2025
@kjplows kjplows moved this to To merge in SBN software development Aug 11, 2025
@kjplows kjplows merged commit 5166730 into develop Aug 11, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Aug 11, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Aug 11, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Sep 12, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_09_00 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change bugfix Addresses one or more bugs

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

5 participants