Skip to content

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Apr 22, 2025

Description

OpFlash information is currently not being saved in CAF files in SBND. This PR splits the FillOpFlash function into two detector-specific functions so the OpFlash information can be filled also for SBND.

Eventually, both functions could be modified to converge into a common function that does the job.

This PR depends on SBNSoftware/sbnanaobj#138

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Apr 22, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 22, 2025

trigger build SBNSoftware/sbnanaobj#138

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Apr 25, 2025
@kjplows kjplows moved this from To merge to Testing in SBN software development Apr 25, 2025
@jzennamo jzennamo removed the request for review from PetrilloAtWork April 28, 2025 14:34
@kjplows kjplows moved this from Testing to To merge in SBN software development Apr 28, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 28, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit 5f31751 into develop Apr 28, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development May 8, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_05_00 milestone Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

Make optical flash information filling detector-agnostic

6 participants